From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] ethdev: remove useless pointer initialization
Date: Mon, 30 Jan 2017 10:40:27 +0100
Message-ID: <1935826.gg7Xp02aHW@xps13>
References: <20170124202835.1271-1-emmanuel.roullit@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Emmanuel Roullit <emmanuel.roullit@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wj0-f180.google.com (mail-wj0-f180.google.com
 [209.85.210.180]) by dpdk.org (Postfix) with ESMTP id 6BA6C3237
 for <dev@dpdk.org>; Mon, 30 Jan 2017 10:40:29 +0100 (CET)
Received: by mail-wj0-f180.google.com with SMTP id uo9so3583361wjc.1
 for <dev@dpdk.org>; Mon, 30 Jan 2017 01:40:29 -0800 (PST)
In-Reply-To: <20170124202835.1271-1-emmanuel.roullit@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2017-01-24 21:28, Emmanuel Roullit:
> Found with clang static analysis:
> lib/librte_ether/rte_ethdev.c:2467:22:
> warning: Value stored to 'dev' during its initialization is never read
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
>                     ^~~   ~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Fixes: 61207d014fc9 ("ethdev: fix data reset when allocating port")

Wrong commit reference.
Fixes: 88ac4396ad29 ("ethdev: add VMDq support")

> Signed-off-by: Emmanuel Roullit <emmanuel.roullit@gmail.com>

Applied, thanks