* [PATCH] Pass verbose flag to kernel module
@ 2014-10-06 16:09 Sergio Gonzalez Monroy
[not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Sergio Gonzalez Monroy @ 2014-10-06 16:09 UTC (permalink / raw)
To: dev-VfR2kkLFssw
---
mk/rte.module.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mk/rte.module.mk b/mk/rte.module.mk
index c4ca3fd..bd3c596 100644
--- a/mk/rte.module.mk
+++ b/mk/rte.module.mk
@@ -78,7 +78,7 @@ build: _postbuild
$(MODULE).ko: $(SRCS_LINKS)
@if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi
@$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \
- CROSS_COMPILE=$(CROSS)
+ V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS)
# install module in $(RTE_OUTPUT)/kmod
$(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko
--
1.9.3
^ permalink raw reply related [flat|nested] 11+ messages in thread[parent not found: <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] Pass verbose flag to kernel module [not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-10-08 17:05 ` Thomas Monjalon 2014-10-09 9:37 ` Sergio Gonzalez Monroy 2014-10-13 16:08 ` De Lara Guarch, Pablo ` (2 subsequent siblings) 3 siblings, 1 reply; 11+ messages in thread From: Thomas Monjalon @ 2014-10-08 17:05 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev-VfR2kkLFssw Hi Sergio, 2014-10-06 17:09, Sergio Gonzalez Monroy: > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > - CROSS_COMPILE=$(CROSS) > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) Please could you explain why it is needed? The variable V should be inherited by the recursive make. It's working without your patch in my test. -- Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Pass verbose flag to kernel module 2014-10-08 17:05 ` Thomas Monjalon @ 2014-10-09 9:37 ` Sergio Gonzalez Monroy [not found] ` <20141009093713.GB23978-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Sergio Gonzalez Monroy @ 2014-10-09 9:37 UTC (permalink / raw) To: Thomas Monjalon; +Cc: dev-VfR2kkLFssw On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > Hi Sergio, > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > --- a/mk/rte.module.mk > > +++ b/mk/rte.module.mk > > @@ -78,7 +78,7 @@ build: _postbuild > > $(MODULE).ko: $(SRCS_LINKS) > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > - CROSS_COMPILE=$(CROSS) > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > Please could you explain why it is needed? > The variable V should be inherited by the recursive make. > It's working without your patch in my test. > Hi Thomas, You are right. If you set V=1 in the commmand line it will inherit and pass it down. In the curent framework, we do not force V to be 1, just to be defined (coud be V=y or V=enable, etc). This patch was just forcing the value to be 1 as it is the required value for the kernel makefiles. It is not a big deal and we could approach this by specifiying on the docs to be V=1 or any other way you think more appropiate? Thanks, Sergio > -- > Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20141009093713.GB23978-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>]
* Re: [PATCH] Pass verbose flag to kernel module [not found] ` <20141009093713.GB23978-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org> @ 2014-10-09 12:15 ` Thomas Monjalon 0 siblings, 0 replies; 11+ messages in thread From: Thomas Monjalon @ 2014-10-09 12:15 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev-VfR2kkLFssw Hi Sergio, 2014-10-09 10:37, Sergio Gonzalez Monroy: > On Wed, Oct 08, 2014 at 07:05:32PM +0200, Thomas Monjalon wrote: > > Hi Sergio, > > > > 2014-10-06 17:09, Sergio Gonzalez Monroy: > > > --- a/mk/rte.module.mk > > > +++ b/mk/rte.module.mk > > > @@ -78,7 +78,7 @@ build: _postbuild > > > $(MODULE).ko: $(SRCS_LINKS) > > > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > > > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ > > > - CROSS_COMPILE=$(CROSS) > > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > > > Please could you explain why it is needed? > > The variable V should be inherited by the recursive make. > > It's working without your patch in my test. > > You are right. If you set V=1 in the commmand line it will inherit and pass it down. > In the curent framework, we do not force V to be 1, just to be defined (coud be V=y > or V=enable, etc). > This patch was just forcing the value to be 1 as it is the required value for the > kernel makefiles. > > It is not a big deal and we could approach this by specifiying on the docs to be V=1 > or any other way you think more appropiate? Oh OK, I didn't imagine passing other value to V ;) It's better to fix makefile than doc. So I'm OK with this patch. -- Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Pass verbose flag to kernel module [not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-10-08 17:05 ` Thomas Monjalon @ 2014-10-13 16:08 ` De Lara Guarch, Pablo [not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> 2014-10-15 13:08 ` [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy 2014-10-15 13:08 ` [PATCH v2] " Sergio Gonzalez Monroy 3 siblings, 1 reply; 11+ messages in thread From: De Lara Guarch, Pablo @ 2014-10-13 16:08 UTC (permalink / raw) To: Gonzalez Monroy, Sergio, dev-VfR2kkLFssw@public.gmane.org > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Monday, October 06, 2014 5:09 PM > To: dev-VfR2kkLFssw@public.gmane.org > Subject: [dpdk-dev] [PATCH] Pass verbose flag to kernel module > > --- > mk/rte.module.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.module.mk b/mk/rte.module.mk > index c4ca3fd..bd3c596 100644 > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) > O=$(RTE_KERNELDIR) \ > - CROSS_COMPILE=$(CROSS) > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > # install module in $(RTE_OUTPUT)/kmod > $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko > -- > 1.9.3 Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>]
* Re: [PATCH] Pass verbose flag to kernel module [not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> @ 2014-10-15 12:04 ` Thomas Monjalon 2014-10-15 13:05 ` Gonzalez Monroy, Sergio 0 siblings, 1 reply; 11+ messages in thread From: Thomas Monjalon @ 2014-10-15 12:04 UTC (permalink / raw) To: De Lara Guarch, Pablo, Gonzalez Monroy, Sergio; +Cc: dev-VfR2kkLFssw Sergio, I'd like to see a v2 patch with your explanations in commit log and with a Signed-off-by. > > - CROSS_COMPILE=$(CROSS) > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) Minor nits: - paren is not needed for one letter variable - V option should go to the end to keep things sorted by importance - CROSS_COMPILE=$(CROSS) + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) > Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Please Pablo, do not give your ack if there is no Signed-off-by. It's mandatory. Thanks -- Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] Pass verbose flag to kernel module 2014-10-15 12:04 ` Thomas Monjalon @ 2014-10-15 13:05 ` Gonzalez Monroy, Sergio 0 siblings, 0 replies; 11+ messages in thread From: Gonzalez Monroy, Sergio @ 2014-10-15 13:05 UTC (permalink / raw) To: Thomas Monjalon, De Lara Guarch, Pablo; +Cc: dev-VfR2kkLFssw@public.gmane.org > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > Sent: Wednesday, October 15, 2014 1:05 PM > To: De Lara Guarch, Pablo; Gonzalez Monroy, Sergio > Cc: dev-VfR2kkLFssw@public.gmane.org > Subject: Re: [dpdk-dev] [PATCH] Pass verbose flag to kernel module > > Sergio, > > I'd like to see a v2 patch with your explanations in commit log and with a > Signed-off-by. > My mistake, I will be more careful to check proper comments and signed-off. V2 on the way. > > > - CROSS_COMPILE=$(CROSS) > > > + V=$(if $(V),1,0) CROSS_COMPILE=$(CROSS) > > Minor nits: > - paren is not needed for one letter variable I don't mind doing this but a quick grep on the current code will show more single letters with parenthesis than without. I was just trying to be consistent with current style. Thanks, Sergio > - V option should go to the end to keep things sorted by importance > > - CROSS_COMPILE=$(CROSS) > + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) > > > Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > > Please Pablo, do not give your ack if there is no Signed-off-by. > It's mandatory. > > Thanks > -- > Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] Set V=1 when building kernel modules [not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-10-08 17:05 ` Thomas Monjalon 2014-10-13 16:08 ` De Lara Guarch, Pablo @ 2014-10-15 13:08 ` Sergio Gonzalez Monroy [not found] ` <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-10-15 13:08 ` [PATCH v2] " Sergio Gonzalez Monroy 3 siblings, 1 reply; 11+ messages in thread From: Sergio Gonzalez Monroy @ 2014-10-15 13:08 UTC (permalink / raw) To: dev-VfR2kkLFssw Linux kernel build system requires V=1 to enable verbose output, but current DPDK framework just check if V is defined. Fix: force V=1 when building Linux kernel modules if verbose output is enabled. Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..34a2ba9 100644 --- a/mk/rte.module.mk +++ b/mk/rte.module.mk @@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ - CROSS_COMPILE=$(CROSS) + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) # install module in $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko -- 1.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] Set V=1 when building kernel modules [not found] ` <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-10-15 13:43 ` Gonzalez Monroy, Sergio 0 siblings, 0 replies; 11+ messages in thread From: Gonzalez Monroy, Sergio @ 2014-10-15 13:43 UTC (permalink / raw) To: Gonzalez Monroy, Sergio, dev-VfR2kkLFssw@public.gmane.org > -----Original Message----- > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Sergio Gonzalez > Monroy > Sent: Wednesday, October 15, 2014 2:08 PM > To: dev-VfR2kkLFssw@public.gmane.org > Subject: [dpdk-dev] [PATCH] Set V=1 when building kernel modules > Self-NACK. Please ignore as I forgot to add v2 prefix. Sergio > Linux kernel build system requires V=1 to enable verbose output, but current > DPDK framework just check if V is defined. > > Fix: force V=1 when building Linux kernel modules if verbose output is > enabled. > > Signed-off-by: Sergio Gonzalez Monroy > <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > mk/rte.module.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..34a2ba9 > 100644 > --- a/mk/rte.module.mk > +++ b/mk/rte.module.mk > @@ -78,7 +78,7 @@ build: _postbuild > $(MODULE).ko: $(SRCS_LINKS) > @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi > @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) > O=$(RTE_KERNELDIR) \ > - CROSS_COMPILE=$(CROSS) > + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) > > # install module in $(RTE_OUTPUT)/kmod > $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko > -- > 1.9.3 ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] Set V=1 when building kernel modules [not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> ` (2 preceding siblings ...) 2014-10-15 13:08 ` [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy @ 2014-10-15 13:08 ` Sergio Gonzalez Monroy [not found] ` <1413378534-15626-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 3 siblings, 1 reply; 11+ messages in thread From: Sergio Gonzalez Monroy @ 2014-10-15 13:08 UTC (permalink / raw) To: dev-VfR2kkLFssw Linux kernel build system requires V=1 to enable verbose output, but current DPDK framework just check if V is defined. Fix: force V=1 when building Linux kernel modules if verbose output is enabled. Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- mk/rte.module.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/rte.module.mk b/mk/rte.module.mk index c4ca3fd..34a2ba9 100644 --- a/mk/rte.module.mk +++ b/mk/rte.module.mk @@ -78,7 +78,7 @@ build: _postbuild $(MODULE).ko: $(SRCS_LINKS) @if [ ! -f $(notdir Makefile) ]; then ln -nfs $(SRCDIR)/Makefile . ; fi @$(MAKE) -C $(RTE_KERNELDIR) M=$(CURDIR) O=$(RTE_KERNELDIR) \ - CROSS_COMPILE=$(CROSS) + CROSS_COMPILE=$(CROSS) V=$(if $V,1,0) # install module in $(RTE_OUTPUT)/kmod $(RTE_OUTPUT)/kmod/$(MODULE).ko: $(MODULE).ko -- 1.9.3 ^ permalink raw reply related [flat|nested] 11+ messages in thread
[parent not found: <1413378534-15626-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] Set V=1 when building kernel modules [not found] ` <1413378534-15626-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-10-15 14:02 ` Thomas Monjalon 0 siblings, 0 replies; 11+ messages in thread From: Thomas Monjalon @ 2014-10-15 14:02 UTC (permalink / raw) To: Sergio Gonzalez Monroy; +Cc: dev-VfR2kkLFssw 2014-10-15 14:08, Sergio Gonzalez Monroy: > Linux kernel build system requires V=1 to enable verbose output, but > current DPDK framework just check if V is defined. > > Fix: force V=1 when building Linux kernel modules if verbose output is > enabled. > > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Acked-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Applied Thanks -- Thomas ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2014-10-15 14:02 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-06 16:09 [PATCH] Pass verbose flag to kernel module Sergio Gonzalez Monroy
[not found] ` <1412611749-7901-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-08 17:05 ` Thomas Monjalon
2014-10-09 9:37 ` Sergio Gonzalez Monroy
[not found] ` <20141009093713.GB23978-IWE99D/oH1/+pXziaqXtF9h3ngVCH38I@public.gmane.org>
2014-10-09 12:15 ` Thomas Monjalon
2014-10-13 16:08 ` De Lara Guarch, Pablo
[not found] ` <E115CCD9D858EF4F90C690B0DCB4D8972262B7FB-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-10-15 12:04 ` Thomas Monjalon
2014-10-15 13:05 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [PATCH] Set V=1 when building kernel modules Sergio Gonzalez Monroy
[not found] ` <1413378491-15573-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-15 13:43 ` Gonzalez Monroy, Sergio
2014-10-15 13:08 ` [PATCH v2] " Sergio Gonzalez Monroy
[not found] ` <1413378534-15626-1-git-send-email-sergio.gonzalez.monroy-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-10-15 14:02 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).