From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v5 01/11] lib/librte_vhost: move src files in vhost example to vhost lib directory Date: Tue, 30 Sep 2014 06:35:04 +0200 Message-ID: <1939857.K6XTWT658S@xps13> References: <1411724758-27488-1-git-send-email-huawei.xie@intel.com> <18610886.dgDN8rLRaO@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Xie, Huawei" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-09-30 02:07, Xie, Huawei: > > In patch 2, you're using main.c to create vhost_rxtx.c. > > So it would be clearer to rename it in this patch 1. > > > Rename it to vhost_rxtx.c? Yes :) And rename virtio-net.h to rte_virtio_net.h. Please put all file renaming in the same patch. Then second patch should be definitive removals. >>From the third patch, you can start reworks. -- Thomas