From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] virtio: allow running w/o vlan filtering Date: Wed, 21 Oct 2015 15:58:05 +0200 Message-ID: <1945608.IVpO5Mj81A@xps13> References: <1425602726-26538-1-git-send-email-stephen@networkplumber.org> <55C1EA34.3000105@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Ouyang, Changchun" To: huawei.xie@intel.com Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 64839E72 for ; Wed, 21 Oct 2015 15:59:11 +0200 (CEST) Received: by wicll6 with SMTP id ll6so92434494wic.0 for ; Wed, 21 Oct 2015 06:59:11 -0700 (PDT) In-Reply-To: <55C1EA34.3000105@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-08-05 12:49, Vincent JARDIN: > > Use '--disable-hw-vlan-filter' in testpmd command line will allow it continue to work. > > You can have a try. > > Yes, but not using this flag should not imply to exit. > > > I am not sure which one is better when app configures one feature but fail to negotiate it with host(which means has > > no such capability to support this feature currently). > > 1)The driver cheat the app, and continue to do the rest of work(of course need some hints). > > 2)give hints and exit, then user re-run app with correct configuration. > > Same as Stephen: > > 3) give hints of capabilities, do not exit, then user app does whatever > it wants (including exit if needed). I would tend to apply this patch but as it was discussed we need some clear acknowledgement. Huawei?