From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 03/15] pmd: Add PMD_REGISTER_DRIVER macro
Date: Fri, 18 Apr 2014 14:08:56 +0200
Message-ID: <1947585.TXBcrJqKvb@xps13>
References: <1397585169-14537-1-git-send-email-nhorman@tuxdriver.com>
 <16254493.92s6zWrT4n@xps13> <20140418120409.GB2812@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <20140418120409.GB2812-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-04-18 08:04, Neil Horman:
> On Fri, Apr 18, 2014 at 04:42:01AM -0700, Thomas Monjalon wrote:
> > 2014-04-15 14:05, Neil Horman:
> > > Rather than have each driver have to remember to add a constructor to it
> > > to
> > > make sure its gets registered properly, wrap that process up in a macro
> > > to
> > > make registration a one line affair.  This also sets the stage for us to
> > > make registration of vdev pmds and physical pmds a uniform process
> > > 
> > > Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
> > > 
> > > --- /dev/null
> > > +++ b/lib/librte_eal/common/include/rte_pmd.h
> > 
> > So you are creating a new header file for PMD API, right?
> > 
> > According to rte_ethdev.h,
> > "The Ethernet Device API is composed of two parts:"
> > "- The application-oriented Ethernet API"
> > "- The driver-oriented Ethernet API"
> > 
> > So we should implement this macro in rte_ethdev.h.
> > But maybe you prefer to split this file in two files. If so, please send a
> > separated patch for that.
> 
> Actually I'm fine with moving the macro to another file, though if I do, I
> think merging it into rte_dev.h is more appropriate, as thats where the
> driver registration function lives.

I'm not sure to understand what you're saying.
My suggestion is to have 2 files in lib/librte_ether: 1 for application API 
and 1 for PMD API.

-- 
Thomas