From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 5/6] doc: remove dpdk iova aware notice
Date: Wed, 25 Oct 2017 11:45:38 +0200
Message-ID: <1947820.k6ijHbkXh2@xps>
References: <20170905103119.20511-1-santosh.shukla@caviumnetworks.com>
 <3176198.eLQH8UvYp5@xps>
 <4cc3e70d-68d1-70e3-a23b-9aa6c37b1738@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, olivier.matz@6wind.com, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com, anatoly.burakov@intel.com
To: santosh <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 5371E9FE
 for <dev@dpdk.org>; Wed, 25 Oct 2017 11:45:40 +0200 (CEST)
In-Reply-To: <4cc3e70d-68d1-70e3-a23b-9aa6c37b1738@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Santosh,

24/10/2017 07:06, santosh:
> Hi Thomas,
> 
> 
> On Tuesday 24 October 2017 01:59 AM, Thomas Monjalon wrote:
> > 20/10/2017 14:31, Santosh Shukla:
> >> Removed dpdk iova aware ABI deprecation notice,
> >> and updated ABI change details in release_17.11.rst.
> >>
> >> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> >> Acked-by: John McNamara <john.mcnamara@intel.com>
> >> ---
> >> --- a/doc/guides/rel_notes/deprecation.rst
> >> +++ b/doc/guides/rel_notes/deprecation.rst
> >> -* eal: An ABI change is planned for 17.11 to make DPDK aware of IOVA address
> >> -  translation scheme.
> >> -  Reference to phys address in EAL data-structure or functions may change to
> >> -  IOVA address or more appropriate name.
> >> -  The change will be only for the name.
> >> -  Functional aspects of the API or data-structure will remain same.
> > Sorry, this series cannot be applied as is because it is breaking
> > more than EAL API. The API of mbuf and mempool are also changed.
> > We need to choose one of these three options:
> > 	1/ accept to break all API in 17.11
> > 	2/ postpone the whole series to 18.02
> 
> Theme of series is to make dpdk iova aware so I would prefer option 1) or 2).
> However I have no strong opinion on this topic. 
> Lets get more opinion from others about option 1/2/3.
> 
> > 	3/ rename only EAL API in 17.11 and postpone mbuf/mempool

After discussing with Olivier it appeared there is a fourth solution.
We should not break any API (EAL, mbuf, mempool).

I would like to merge these changes in RC2, but keeping compatibility
with old names:
- When you rename a function or a type, you can define a macro for the
old name, alias the new name.
- When you rename a struct field, you can make an anonymous union
to allow both names.

Then we can deprecate the old names and remove them later.

Are you able to do these small changes today please?