From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] eal: fix check number of bytes from read function Date: Fri, 22 Jul 2016 01:09:10 +0200 Message-ID: <1948737.G1euFzQ2ex@xps13> References: <1469024689-1076-1-git-send-email-michalx.k.jastrzebski@intel.com> <1862165.0hl8WtbyGd@xps13> <60ABE07DBB3A454EB7FAD707B4BB158213AB97E7@irsmsx110.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Richardson, Bruce" , "Kobylinski, MichalX" , "Gonzalez Monroy, Sergio" , "david.marchand@6wind.com" To: "Jastrzebski, MichalX K" Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id F183C5585 for ; Fri, 22 Jul 2016 01:09:12 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id i5so43323926wmg.0 for ; Thu, 21 Jul 2016 16:09:12 -0700 (PDT) In-Reply-To: <60ABE07DBB3A454EB7FAD707B4BB158213AB97E7@irsmsx110.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-21 20:50, Jastrzebski, MichalX K: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > - (int)sizeof(uint64_t) can be replaced by 8 but it's shorter ;) > > I didn't want to change all invokes of read() function here. > I can use some macro: > #define PFN_MASK_SIZE 8 > How do You think? Yes may be an idea.