From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 00/28] introduce I/O device memory read/write operations Date: Fri, 16 Dec 2016 18:04:29 +0100 Message-ID: <19499490.j98SqyhBfx@xps13> References: <1481680558-4003-1-git-send-email-jerin.jacob@caviumnetworks.com> <20161214025357.GF18991@yliu-dev.sh.intel.com> <20161214131835.GB4224@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Yuanhan Liu , dev@dpdk.org, konstantin.ananyev@intel.com, bruce.richardson@intel.com, jianbo.liu@linaro.org, viktorin@rehivetech.com To: Jerin Jacob Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id A9EDFF928 for ; Fri, 16 Dec 2016 18:04:31 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id t79so42703840wmt.0 for ; Fri, 16 Dec 2016 09:04:31 -0800 (PST) In-Reply-To: <20161214131835.GB4224@localhost.localdomain> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-14 18:48, Jerin Jacob: > On Wed, Dec 14, 2016 at 10:53:57AM +0800, Yuanhan Liu wrote: > > On Wed, Dec 14, 2016 at 07:25:30AM +0530, Jerin Jacob wrote: > > > patchset 14-28: Replace the raw readl/writel in the drivers with > > > new rte_read[b/w/l/q], rte_write[b/w/l/q] eal abstraction > > > > Instead of rte_read[b/w/l/q], there is another typical naming style: > > rte_read[8/16/32/64]. Any preferences? If you ask me, I'd prefer the > > later. > > No strong opinion here. The rte_read[b/w/l/q] naming style is from Linux > kernel. I will change to rte_read[8/16/32/64] in v2 if there is no > objection. Yes please. Let's use numbers where possible. See this recent explanation: http://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1293045.html