From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Traynor Subject: Re: [PATCH v2] net/qede: fix L2-handles used for RSS hash update Date: Wed, 6 Jun 2018 12:11:41 +0100 Message-ID: <194b5308-92a1-32b0-55fa-491d1fae24fb@redhat.com> References: <1527873381-23910-1-git-send-email-rasesh.mody@cavium.com> <1528239837-6424-1-git-send-email-rasesh.mody@cavium.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: ferruh.yigit@intel.com, Dept-EngDPDKDev@cavium.com, stable@dpdk.org To: Rasesh Mody , dev@dpdk.org Return-path: In-Reply-To: <1528239837-6424-1-git-send-email-rasesh.mody@cavium.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/06/2018 12:03 AM, Rasesh Mody wrote: > Fix fast path array index which is used for passing L2 handles to RSS > indirection table, properly distribute rxq handles for indirection table. > Currently, it is using the local copy of indirection table. When the RX > queue configuration changes the local copy becomes invalid. > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS configuration") > Cc: stable@dpdk.org > > Signed-off-by: Rasesh Mody > Reviewed-by: Kevin Traynor LGTM > --- > drivers/net/qede/qede_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c > index 3206cc6..5a4071b 100644 > --- a/drivers/net/qede/qede_ethdev.c > +++ b/drivers/net/qede/qede_ethdev.c > @@ -2210,7 +2210,7 @@ int qede_rss_hash_update(struct rte_eth_dev *eth_dev, > vport_update_params.vport_id = 0; > /* pass the L2 handles instead of qids */ > for (i = 0 ; i < ECORE_RSS_IND_TABLE_SIZE ; i++) { > - idx = qdev->rss_ind_table[i]; > + idx = i % QEDE_RSS_COUNT(qdev); > rss_params.rss_ind_table[i] = qdev->fp_array[idx].rxq->handle; > } > vport_update_params.rss_params = &rss_params; >