From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] Fix bash path in shebangs Date: Wed, 13 Sep 2017 17:39:43 +0200 Message-ID: <1950575.vEqoHlsAsr@xps> References: <20170727201212.9252-1-asomers@gmail.com> <2043146.lLI0On9UDY@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: alan somers Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 138BC9FE for ; Wed, 13 Sep 2017 17:39:45 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 13/09/2017 16:35, alan somers: > On Wed, Sep 13, 2017 at 3:37 AM, Thomas Monjalon wrote: > > 27/07/2017 22:12, asomers@gmail.com: > >> From: Alan Somers > >> > >> "/bin/bash" is a Linuxism. "/usr/bin/env bash" is portable. > > > > Why is it an issue? > > > > Can you run dpdk-setup.sh on a non-Linux system? > > Nope, because even dpdk-setup.sh assumes that bash is located at > /bin/bash. But "/usr/bin/env bash" works everywhere. No, I mean: can you run dpdk-setup.sh on a non-Linux system after your change? This script configures a Linux system, so I want to understand what situation you are trying to fix.