From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] kni: fix build on Linux < 3.14 Date: Sat, 27 Oct 2018 01:25:16 +0200 Message-ID: <19506887.xJU308vF1C@xps> References: <20181026214027.29465-1-thomas@monjalon.net> <4880956.RWMF3eIYHy@xps> <809e8e42-0deb-e53d-f5e4-acd4bc2f5d0b@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: Ferruh Yigit , phil.yang@arm.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com To: dev@dpdk.org Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id D1C192E81 for ; Sat, 27 Oct 2018 01:25:11 +0200 (CEST) In-Reply-To: <809e8e42-0deb-e53d-f5e4-acd4bc2f5d0b@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2018 00:42, Ferruh Yigit: > On 10/26/2018 10:56 PM, Thomas Monjalon wrote: > > 26/10/2018 23:40, Thomas Monjalon: > >> The atomic functions smp_load_acquire() and smp_store_release() > >> were introduced in Linux 3.14. Older kernels miss the functions: > >> > >> kni_fifo.h:19:2: error: > >> implicit declaration of function =E2=80=98smp_load_acquire=E2=80=99 > >> kni_fifo.h:30:2: error: > >> implicit declaration of function =E2=80=98smp_store_release=E2=80=99 > >> > >> The fallback is to drop the atomic barrier, as it was before > >> the commit below. > >> > >> Fixes: 711859cd0d07 ("kni: fix kernel FIFO synchronization") > >> > >> Signed-off-by: Thomas Monjalon >=20 > Tested-by: Ferruh Yigit Applied