From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] ip_pipeline: fix parsing error in TM port section Date: Tue, 21 Jun 2016 22:49:29 +0200 Message-ID: <19575533.UNkKiejxmv@xps13> References: <1466067875-165380-1-git-send-email-jasvinder.singh@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Jasvinder Singh To: cristian.dumitrescu@intel.com Return-path: Received: from mail-lf0-f52.google.com (mail-lf0-f52.google.com [209.85.215.52]) by dpdk.org (Postfix) with ESMTP id 3D4FA6CD3 for ; Tue, 21 Jun 2016 22:49:32 +0200 (CEST) Received: by mail-lf0-f52.google.com with SMTP id q132so42822996lfe.3 for ; Tue, 21 Jun 2016 13:49:32 -0700 (PDT) In-Reply-To: <1466067875-165380-1-git-send-email-jasvinder.singh@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-06-16 10:04, Jasvinder Singh: > Replace APP_PARAM_ADD_LINK_FOR_TXQ with APP_PARAM_ADD_LINK_FOR_TM macro > in TM (Traffic Manager) port section parsing function. This macro adds > nic ports entry specified in TM port section of the application > configuration file to the application parameters structure. > > Fixes: e5a1cd8a4847 ("examples/ip_pipeline: clean up configuration parser") > > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu Already fixed in 81d084dd2aa8 ("examples/ip_pipeline: support KNI") Cristian, you should not ack a patch which do more than announced in the title. This pipeline KNI patch do a lot of things without any explanation for the fixes. 1 explanation = 1 patch