From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: checkpatch script Date: Tue, 25 Nov 2014 15:28:41 +0100 Message-ID: <1958676.MmbbGzbMYp@xps13> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "De Lara Guarch, Pablo" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Pablo, 2014-11-25 13:11, De Lara Guarch, Pablo: > Hi Thomas, > > As we have seen the issues we have had on previous patches due to > checkpatch, No we have no issues because of checkpatch ;) It helps us to see some obvious errors. > would it be possible to include the up-to-date script in the > repo? I have realized that people either do not check their patches or check > them with an old version that do not catch some errors that the latest one > does, so I think this is a problem. The real problem is to clearly define all the coding rules and adapt checkpatch to our needs. > Plus, I think it would be a good idea to mention it in dpdk.org/dev, as this > is clearly a requirement for merging patches. Please, let's close DPDK 1.8 first. Then we'll have to write some documents and tools to make them approved after necessary discussions/debates. -- Thomas