From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 5/6] ixgbe: support VxLAN & NVGRE TX checksum off-load Date: Mon, 15 Feb 2016 11:03:27 +0100 Message-ID: <1958817.fmrgW3e0Zp@xps13> References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <2601191342CEEE43887BDE71AB97725836B03304@irsmsx105.ger.corp.intel.com> <6A0DE07E22DDAD4C9103DF62FEBC09090342A92F@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Lu, Wenzhuo" Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 66115592A for ; Mon, 15 Feb 2016 11:04:59 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id c200so104884182wme.0 for ; Mon, 15 Feb 2016 02:04:59 -0800 (PST) In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09090342A92F@shsmsx102.ccr.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-02-15 05:32, Lu, Wenzhuo: > From: Ananyev, Konstantin > > From reading X550 spec, I don't really understand what for we need to specify is > > it GRE or VXLAN packet, so probably we don't need that flag for now at all? > The reason is we need to set the tunnel type in the Advanced Transmit Data Descriptor. Why don't we use packet type? > > If we really do, might bw worth to organise it like KT_TX_L4_CKSUM (as enum) > > and reserve few values for future expansion (2 or 3 bits?). > Now there're only VxLAN and NVGRE supported. So, only 1 bit is occupied for that. Not sure if more types will be supported in the future. Any suggestions? Thanks. Yes there can be a lot of tunnel types. Please check RTE_PTYPE_TUNNEL_*