From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [PATCH v4 1/2] testpmd: add forwarding mode to
 simulate a noisy neighbour
Date: Fri, 29 Jun 2018 15:38:02 +0200
Message-ID: <195bb20b-441a-571e-8925-6db0a8af56c2@redhat.com>
References: <20180623080840.315-1-maxime.coquelin@redhat.com>
 <20180623080840.315-2-maxime.coquelin@redhat.com>
 <8CEF83825BEC744B83065625E567D7C260CB8BEC@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "ailan@redhat.com" <ailan@redhat.com>,
 "jan.scheurich@ericsson.com" <jan.scheurich@ericsson.com>,
 "vkaplans@redhat.com" <vkaplans@redhat.com>,
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 "thomas@monjalon.net" <thomas@monjalon.net>,
 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Jens Freimann <jfreimann@redhat.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 6FB962BDF
 for <dev@dpdk.org>; Fri, 29 Jun 2018 15:38:07 +0200 (CEST)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260CB8BEC@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Bernard,

On 06/26/2018 01:09 PM, Iremonger, Bernard wrote:
> checkpatch.pl  is showing the following warnings:
> 
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
> #122: FILE: app/test-pmd/noisy_vnf.c:1:
> +/* SPDX-License-Identifier: BSD-3-Clause

I'm not sure to get what is wrong here, any thoughts?

<snip/>

> WARNING: line over 80 characters
> #394: FILE: app/test-pmd/parameters.c:1154:
> +                       if (!strcmp(lgopts[opt_idx].name, "noisy-buffersize-before-sending")) {
> 
> WARNING: line over 80 characters
> #402: FILE: app/test-pmd/parameters.c:1162:
> +                       if (!strcmp(lgopts[opt_idx].name, "noisy-flush-timeout")) {
> 
> WARNING: line over 80 characters
> #410: FILE: app/test-pmd/parameters.c:1170:
> +                       if (!strcmp(lgopts[opt_idx].name, "noisy-memory-footprint")) {
> 
> WARNING: line over 80 characters
> #413: FILE: app/test-pmd/parameters.c:1173:
> +                                       noisy_vnf_memory_footprint = (uint16_t) n;
> 
> WARNING: line over 80 characters
> #418: FILE: app/test-pmd/parameters.c:1178:
> +                       if (!strcmp(lgopts[opt_idx].name, "noisy-nb-rnd-write")) {
> 
> WARNING: line over 80 characters
> #426: FILE: app/test-pmd/parameters.c:1186:
> +                       if (!strcmp(lgopts[opt_idx].name, "noisy-nb-rnd-read")) {
> 
> WARNING: line over 80 characters
> #434: FILE: app/test-pmd/parameters.c:1194:
> +                       if (!strcmp(lgopts[opt_idx].name, "noisy-nb-rnd-read-write")) {

The above ones were left intentionally for consistency with code around
them.

Should I fix them? (I'm fine doing it if you prefer)

Thanks,
Maxime

> total: 0 errors, 12 warnings, 454 lines checked
> 
> Regards,
> 
> Bernard.