From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] doc: show version in html guides
Date: Fri, 18 Dec 2015 17:03:28 +0100
Message-ID: <19602739.ahHbYTFq96@xps13>
References: <1450347992-25835-1-git-send-email-thomas.monjalon@6wind.com>
 <69070363.GR6IPDgz4Q@xps13>
 <B27915DBBA3421428155699D51E4CFE202409E30@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Mcnamara, John" <john.mcnamara@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 71FD07E23
 for <dev@dpdk.org>; Fri, 18 Dec 2015 17:04:44 +0100 (CET)
Received: by mail-wm0-f42.google.com with SMTP id l126so71565106wml.1
 for <dev@dpdk.org>; Fri, 18 Dec 2015 08:04:44 -0800 (PST)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE202409E30@IRSMSX103.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-12-18 12:41, Mcnamara, John:
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > 2015-12-18 10:27, Mcnamara, John:
> > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> > > > The version does not appear in the readthedocs theme.
> > > > We may try to customize the theme, or just update the project name
> > > > as in this patch. The project name is not used in the PDF.
> > >
> > > Hi,
> > >
> > > I see the version number in generated docs:
> > >
> > >     http://i.imgur.com/GkvNz2U.png
> > 
> > Interesting.
> > 
> > > However, I can see that it doesn't appear on the dpdk.org version.
> > >
> > > I am using:
> > >
> > >     $ sphinx-build --version
> > >     Sphinx (sphinx-build) 1.3.1
> > 
> > Same version on dpdk.org.
> > There should be something else different...
> 
> 
> It could be the version of the RTD theme:
> 
> 
>     $ python -c "import sphinx_rtd_theme; print sphinx_rtd_theme.__version__"
>     0.1.9
> 
> 0.1.9 is required for the version number in the Navbar:
> 
>     https://github.com/snide/sphinx_rtd_theme#v0-1-9

0.1.8 here.

So this patch is rejected and the doc should be regenerated on dpdk.org.

Thanks