From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/2] ethdev: add buffered tx api Date: Wed, 09 Mar 2016 15:25:52 +0100 Message-ID: <1964417.t7N6HDkJH0@xps13> References: <1452869038-9140-1-git-send-email-tomaszx.kulasek@intel.com> <4446137.g0qt5Fe5Df@xps13> <2601191342CEEE43887BDE71AB97725836B1A4A2@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Ananyev, Konstantin" Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id F20342BF4 for ; Wed, 9 Mar 2016 15:27:32 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id p65so194732075wmp.1 for ; Wed, 09 Mar 2016 06:27:32 -0800 (PST) In-Reply-To: <2601191342CEEE43887BDE71AB97725836B1A4A2@irsmsx105.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-09 13:36, Ananyev, Konstantin: > > > + if (to_send == 0) > > > + return 0; > > > > Why this check is done in the lib? > > What is the performance gain if we are idle? > > It can be done outside if needed. > > Yes, that could be done outside, but if user has to do it anyway, > why not to put it inside? > I don't expect any performance gain/loss because of that - > just seems a bit more convenient to the user. It is handling an idle case so there is no gain obviously. But the condition branching is surely a loss. So why the user would you like to do this check?