From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: register rte_panic user callback
Date: Wed, 07 Mar 2018 16:06:22 +0100
Message-ID: <1968690.y4bVNFghIW@xps>
References: <1520360928-9375-1-git-send-email-arnon@qwilt.com>
 <81ecbc4a-0200-3b42-8da1-fe87e8c14c04@intel.com>
 <CAKy9EB1SaOVFDyDnszTJUGH9gON5-ULRf86kRcxRXT6WiPMWjg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
To: Arnon Warshavsky <arnon@qwilt.com>, "Burakov,
 Anatoly" <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 71D4A4CA1
 for <dev@dpdk.org>; Wed,  7 Mar 2018 16:07:11 +0100 (CET)
In-Reply-To: <CAKy9EB1SaOVFDyDnszTJUGH9gON5-ULRf86kRcxRXT6WiPMWjg@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

07/03/2018 14:23, Arnon Warshavsky:
> >
> > Can we add a compile warning for adding new rte_panic's into code? It's a
> > nice tool while debugging, but it probably shouldn't be in any new
> > production code.

Yes could be nice to automatically detect it in drivers/ or lib/ directories.


> I thought about renaming the current function and calls to something like
> deprecated_rte_panic()
> , and keep the old API with __rte_deprecated.
> Is this kind of API break acceptable?

No, rte_panic can be used in applications.