From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devargs: fix scan mode configuration in add Date: Wed, 02 Aug 2017 16:32:38 +0200 Message-ID: <1970205.aClgWgp9Kr@xps> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Gaetan Rivet Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6CD0BA0F2 for ; Wed, 2 Aug 2017 16:32:40 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 02/08/2017 10:55, Gaetan Rivet: > When adding rte_devargs to the list, a check is performed on the > intended bus that should use this rte_devargs. This bus configuration is > for the time being only set once when the first rte_devargs is added to > it. If the bus configuration has previously been set, then the rte_devargs > insertion fails. Sorry, I don't understand which logic is changed :) Maybe it would be easier with an example? > Failure occuring upon detection of the set configuration is an API > change. While rules will certainly be enforced in the next rte_devargs > API, none were previously enforced and this should be respected until > this API is deprecated. > > The bus configuration is meant to evolve soon, but in the meantime it > should strictly follow the current rte_eal_devargs_add API. > > The rte_devargs unit tests are failing due to this API change. Revert > this evolution, it will be reintroduced properly in the next release if > necessary. So this is a revert. I think the title start with "revert" instead of "fix" as you seem to go back to the old behaviour.