From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v6 7/8] eal: enable PCI bus
Date: Tue, 17 Jan 2017 10:34:19 +0530
Message-ID: <19704d1e-a306-5ee3-b90f-b6419c88c5f2@nxp.com>
References: <1484581107-2025-1-git-send-email-shreyansh.jain@nxp.com>
 <1484581107-2025-8-git-send-email-shreyansh.jain@nxp.com>
 <e55e3020-2750-1219-b9a3-f608a4b43dbe@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <david.marchand@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0067.outbound.protection.outlook.com [104.47.38.67])
 by dpdk.org (Postfix) with ESMTP id D41E3591E
 for <dev@dpdk.org>; Tue, 17 Jan 2017 06:00:55 +0100 (CET)
In-Reply-To: <e55e3020-2750-1219-b9a3-f608a4b43dbe@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tuesday 17 January 2017 01:28 AM, Ferruh Yigit wrote:
> On 1/16/2017 3:38 PM, Shreyansh Jain wrote:
>> Remove EAL initiated direct PCI scan/probe and enable PCI Bus linkage.
>>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
>> ---
>
> <...>
>
>> -/* Init the PCI EAL subsystem */
>> -int
>> -rte_eal_pci_init(void)
>> -{
>> -	/* for debug purposes, PCI can be disabled */
>> -	if (internal_config.no_pci)
>> -		return 0;
>
> Are we losing this feature? Should this check moved to rte_eal_pci_scan() ?

Yes, that is miss from my side. v5 had this, but I missed in v6 in all 
that code movement. I will add that to rte_eal_pci_scan.
Thanks for highlighting.

>
> <...>
>
>