From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] ethdev: add return code to rte_eth_stats_reset() Date: Tue, 08 Aug 2017 15:13:04 +0200 Message-ID: <1971255.B48bYt7Eqt@xps> References: <20170807173914.36750-1-dharton@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Van Haaren, Harry" , dev@dpdk.org To: Christian Ehrhardt , David Harton Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 875972BC9 for ; Tue, 8 Aug 2017 15:13:20 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/08/2017 13:03, Christian Ehrhardt: > On Tue, Aug 8, 2017 at 11:02 AM, Van Haaren, Harry < > harry.van.haaren@intel.com> wrote: > > > > > > Some devices do not support reset of eth stats. An application may > > > need to know not to clear shadow stats if the device cannot. > > > > > > rte_eth_stats_reset is updated to provide a return code to share > > > whether the device supports reset or not. > > > > > > Signed-off-by: David Harton > > > --- > > > > Hi, > > > > As far as I know changing the return type (void to int) of a function does > > *not* break ABI, but does "break" API as the application code should now > > check the return value. In theory the application could ignore the return > > value and current behavior is maintained. > > > > After discussing with Harry on IRC it turns out we both ended up checking > the same online sources > to verify our thoughts, like [1]. > > Given this and several other sources it seems to be as outlined above an > API but not ABI break. > I'm not an expert and this is mostly opinion, but my personal rule mostly > is: "if in doubt bump it". Anyway, the ABI will be broken (and bumped) again in 17.11. This patch will be accepted in 17.11.