From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Making rte_eal_pci_probe() in rte_eal_init() optional? Date: Tue, 17 Nov 2015 16:46:54 +0100 Message-ID: <1972675.qABnqcockr@xps13> References: <564B3215.9020103@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Don Provan To: "Roger B. Melton" Return-path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 8C9732E8D for ; Tue, 17 Nov 2015 16:48:08 +0100 (CET) Received: by wmdw130 with SMTP id w130so160785973wmd.0 for ; Tue, 17 Nov 2015 07:48:08 -0800 (PST) In-Reply-To: <564B3215.9020103@cisco.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-17 08:56, Roger B. Melton: > Hi David, in-line -Roger > > On 11/16/15 4:46 AM, David Marchand wrote: > > Hello Roger, > > > > On Sun, Nov 15, 2015 at 3:45 PM, Roger B. Melton > > wrote: > > > > I like the "-b all" and "-w none" idea, but I think it might be > > complicated to implement it the way we would need it to work. The > > existing -b and -w options persist for the duration of the > > application, and we would need the "-b all"/"-w none" to persists > > only through rte_eal_init() time. Otherwise our attempt to to > > attach a device at a later time would be blocked by the option. > > > > I agree, the black/white lists should only apply to initial scan. > > I forgot about this problem ... > > I had started some cleanup in the pci scan / attach code but this is > > too late for 2.2, I will post this in the next merge window. > > > > > > Wouldn't it be simpler to have an option to disable the > > rte_eal_init() time the probe. Would that address the issue with > > VFIO, prevent automatically attaching to devices while permitting > > on demand attach? > > > > > > I suppose we can do this yes (I think Thomas once proposed off-list an > > option like --no-pci-scan). > > Do you think you can send a patch ? > > What about --no-pci-init-probe? I know it's long, but it is more > descriptive of it's purpose to disable only the init time pci probe. Why not a "-b all"? Making it work would also solve the case where you to scan only part of the devices and initialize the blacklisted ones later.