From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v3] service: fix memory leak by rte_service_init Date: Fri, 26 Jan 2018 17:54:45 +0100 Message-ID: <1976827.tOLhCWFkBG@xps> References: <1515694853-7949-1-git-send-email-vipin.varghese@intel.com> <1517000136-24802-1-git-send-email-vipin.varghese@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Van Haaren, Harry" , "stable@dpdk.org" To: "Varghese, Vipin" Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 26/01/2018 16:20, Van Haaren, Harry: > > From: Varghese, Vipin > > Sent: Friday, January 26, 2018 8:56 PM > > To: Van Haaren, Harry ; dev@dpdk.org > > Cc: stable@dpdk.org; Varghese, Vipin > > Subject: [PATCH v3] service: fix memory leak by rte_service_init > > > > The rte_service_finalize routine checks if service is initialized > > or not. If yes; releases internal memory for services and lcore > > states are freed. This routine is to be invoked at end of application > > termination. > > > > Fixes: 21698354c832 ("service: introduce service cores concept") > > Cc: harry.van.haaren@intel.com > > > > Signed-off-by: Vipin Varghese > > > Thanks Vipin! > > @Stable - this patches allows for fixes secondary processes that > init and quit often, to avoid leaking hugepages memory. As such, > I think it is valuable to include in stable. > > Acked-by: Harry van Haaren Applied, thanks