From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v11 00/24] Introducing rte_driver/rte_device generalization Date: Tue, 04 Oct 2016 09:42:12 +0200 Message-ID: <1978706.bfODzZLsTC@xps13> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <3582057.BR181DtlIn@xps13> <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, viktorin@rehivetech.com, David Marchand , hemant.agrawal@nxp.com To: Shreyansh Jain Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id D90D8558C for ; Tue, 4 Oct 2016 09:42:19 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id f193so150549078wmg.0 for ; Tue, 04 Oct 2016 00:42:19 -0700 (PDT) In-Reply-To: <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-04 12:21, Shreyansh Jain: > Hi Thomas, > > On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote: > > Applied, thanks everybody for the great (re)work! > > Thanks! > > > > > 2016-09-20 18:11, Shreyansh Jain: > >> Future Work/Pending: > >> =================== > >> - Presently eth_driver, rte_eth_dev are not aligned to the rte_driver/ > >> rte_device model. eth_driver still is a PCI specific entity. This > >> has been highlighted by comments from Ferruh in [9]. > >> - Some variables, like drv_name (as highlighted by Ferruh), are getting > >> duplicated across rte_xxx_driver/device and rte_driver/device. > > Both the above are already part of my todo list. > > > What about those pending work? > > > > I would add more remaining issues: > > - probe/remove naming could be applied to vdev for consistency > > Is that for uniformity reasons? I still feel 'probe/remove' are not > appropriate for a virtual device. init/deinit are more appropriate. As > for PCI, probe/remove are standard parlance and hence suit it better > than init/deinit. PCI probe is "scan + checks + init". The vdev requires "args parsing + checks + init". The device will not be initialized if checks fail, e.g. missing support or name conflict. I think it could fit in "probe" rather than "init". The remove word looks appropriate in both cases. > Nevertheless, uniform naming convention can have its benefits - ease of > code understanding being one. Yes that's the other pro for "probe/remove". > Change is simple once we come to a conclusion. > > > - rte_eal_device_insert must be called in vdev > > Ok. > > > - REGISTER macros should be prefixed with RTE_ > > That would include: > DRIVER_REGISTER_VDEV > DRIVER_REGISTER_PCI_TABLE > DRIVER_REGISTER_PCI > > I will publish a patch soon. This would be fairly straightforward change. > > > - Some functions in EAL does not need eal_ in their prefix: > > rte_eal_pci_ -> rte_pci_ > > rte_eal_dev_ -> rte_dev_ > > rte_eal_vdev_ -> rte_vdev_ > > rte_eal_driver -> rte_drv_ > > rte_eal_vdrv -> rte_vdrv_ > > > > > > It can be merged with changes for: > - drv_name > - EAL_ before _REGISTER_ macros > - eth_driver => rte_driver naming Good. Could you make it this week, please?