From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v11 00/24] Introducing rte_driver/rte_device
 generalization
Date: Tue, 18 Oct 2016 10:23:19 +0100
Message-ID: <197a12fd-863a-b79a-f4b4-738636da7625@intel.com>
References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com>
 <3582057.BR181DtlIn@xps13> <629b0e70-5bd1-d376-4fb9-e7c7a102d79f@nxp.com>
 <1978706.bfODzZLsTC@xps13> <de7b3b3b-7a29-f2a8-bc56-df4e4ec0717d@nxp.com>
 <1e1ac980-d857-877b-d629-8a6e9fd0a4c1@intel.com>
 <DB5PR0401MB20542677779F3ACDA49F07D990D00@DB5PR0401MB2054.eurprd04.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "viktorin@rehivetech.com" <viktorin@rehivetech.com>,
 David Marchand <david.marchand@6wind.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id ADC3629CD
 for <dev@dpdk.org>; Tue, 18 Oct 2016 11:23:22 +0200 (CEST)
In-Reply-To: <DB5PR0401MB20542677779F3ACDA49F07D990D00@DB5PR0401MB2054.eurprd04.prod.outlook.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/17/2016 6:29 PM, Shreyansh Jain wrote:
> Hi Ferruh,
> 
>> -----Original Message-----
>> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
>> Sent: Monday, October 17, 2016 7:13 PM
>> To: Shreyansh Jain <shreyansh.jain@nxp.com>; Thomas Monjalon
>> <thomas.monjalon@6wind.com>
>> Cc: dev@dpdk.org; viktorin@rehivetech.com; David Marchand
>> <david.marchand@6wind.com>; Hemant Agrawal <hemant.agrawal@nxp.com>
>> Subject: Re: [dpdk-dev] [PATCH v11 00/24] Introducing rte_driver/rte_device
>> generalization
>>
>> On 10/5/2016 12:57 PM, Shreyansh Jain wrote:
>>> Hi Thomas,
>>>
>>> On Tuesday 04 October 2016 01:12 PM, Thomas Monjalon wrote:
>>>> 2016-10-04 12:21, Shreyansh Jain:
>>>>> Hi Thomas,
>>>>>
>>>>> On Monday 03 October 2016 07:58 PM, Thomas Monjalon wrote:
>>>>>> Applied, thanks everybody for the great (re)work!
>>>>>
>>>>> Thanks!
>>>>>
>>> [...]
>>> [...]
>>>>>
>>>>> It can be merged with changes for:
>>>>>   - drv_name
>>>>>   - EAL_ before _REGISTER_ macros
>>>>>   - eth_driver => rte_driver naming
>>>>
>>>> Good.
>>>> Could you make it this week, please?
>>>>
>>>
>>> Certainly. At least some of those I can send within this week :)
>>>
>>
>>
>> I caught while running ABI validation script today, I think this patch
>> should increase LIBABIVER of:
>> - lib/librte_cryptodev
>> - lib/librte_eal
>> - lib/librte_ether
>  
> Should I be referring to [1] for understanding how/when to change the LIBABIVER?
> 
> [1] http://dpdk.org/doc/guides/contributing/versioning.html

Yes, this is the document.

Briefly, if library becomes incompatible with existing applications,
LIBABIVER needs to be increased to indicate this.

Increasing LIBABIVER changes dynamic library name and so_name, and this
cause existing application do not work with this new library. Not
increasing the LIBABIVER, app may start running but can have segfault or
can generate wrong values. So increasing LIBABIVER is to inform user and
prevent surprises.