From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-maintainers] Example(Load_balancer) Tx Flush
	Bug(This bug DPDK each version)
Date: Mon, 16 Jan 2017 15:18:47 +0100
Message-ID: <1982394.bHk3uHp29x@xps13>
References: <2016122121181642100644@raisecom.com>
 <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16EDCC97E@SHSMSX101.ccr.corp.intel.com>
 <2017011619162170012425@raisecom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Maple <liujian@raisecom.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com
 [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 57A67106A
 for <dev@dpdk.org>; Mon, 16 Jan 2017 15:18:49 +0100 (CET)
Received: by mail-lf0-f53.google.com with SMTP id n124so15580619lfd.2
 for <dev@dpdk.org>; Mon, 16 Jan 2017 06:18:49 -0800 (PST)
In-Reply-To: <2017011619162170012425@raisecom.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

Sorry if you feel your patch is ignored.
It is not in the right format for several reasons we tried
to explain earlier I think.
Please read carefully this doc:
	http://dpdk.org/doc/guides/contributing/patches.html


2017-01-16 19:16, Maple:
> From: Maple <liujian@raisecom.com>
> To: <qiming.yang@intel.com>;<dev@dpdk.org>
> Cc: <maintainers@dpdk.org>
> Subject: [PATCH] Load_balancer Tx Flush Bug
> Date: Mon, 16 Dec 2017 19:15:48 +0800
> Message-Id: <1482371868-19669-1-git-send-email-liujian@raisecom.com>
> X-Mailer: git-send-email 1.9.1
> In-Reply-To: <2016122122394164225248@raisecom.com>
> References: <2016122122394164225248@raisecom.com>
> 
> We found a bug in use load_balancer example,and,This bug DPDK each version.
> In IO tx flush, only flush port 0.
> So,If I enable more than the Port,then,In addition to 0 port won't flush.
> 
> Signed-off-by: Maple <liujian@raisecom.com>
> ---
>  a/examples/load_balancer/runtime.c | 667 ++++++++++++++++++++++++++++++++++++
>  b/examples/load_balancer/runtime.c | 669 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 1336 insertions(+)
>  create mode 100644 a/examples/load_balancer/runtime.c
>  create mode 100644 b/examples/load_balancer/runtime.c
> 
> diff --git a/examples/load_balancer/runtime.c b/examples/load_balancer/runtime.c
> index 9612392..3a2e900 100644
> --- a/test/a/examples/load_balancer/runtime.c
> +++ b/test/b/examples/load_balancer/runtime.c
> @@ -418,9 +418,11 @@ app_lcore_io_tx(
>  static inline void
>  app_lcore_io_tx_flush(struct app_lcore_params_io *lp)
>  {
> +       uint8_t i;
>         uint8_t port;
> 
> -       for (port = 0; port < lp->tx.n_nic_ports; port ++) {
> +       port = lp->tx.nic_ports[0];
> +       for (i = 0; i < lp->tx.n_nic_ports; i ++) {
>                 uint32_t n_pkts;
> 
>                 if (likely((lp->tx.mbuf_out_flush[port] == 0) ||
>