From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/3] nic_uio: Fix to allow any device to be bound to nic_uio Date: Mon, 20 Jul 2015 01:23:45 +0200 Message-ID: <1983160.fsyPZ7InvC@xps13> References: <4ddacaea168239cb2fdccfacf44906b57948f190.1437156076.git.rahul.lakkireddy@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Felix Marti , Nirranjan Kirubaharan , Kumar Sanghvi To: Rahul Lakkireddy Return-path: Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id 788979655 for ; Mon, 20 Jul 2015 01:24:56 +0200 (CEST) Received: by wgav7 with SMTP id v7so52954524wga.2 for ; Sun, 19 Jul 2015 16:24:56 -0700 (PDT) In-Reply-To: <4ddacaea168239cb2fdccfacf44906b57948f190.1437156076.git.rahul.lakkireddy@chelsio.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-17 23:50, Rahul Lakkireddy: > nic_uio requires the pci ids to be present in rte_pci_dev_ids.h in order to > bind the devices to nic_uio. However, it's better to remove this whitelist of > pci ids, and instead rely on hw.nic_uio.bdfs kenv parameter to allow binding > any device to nic_uio. [...] > - for (i = 0; i < NUM_DEVICES; i++) > - if (pci_get_vendor(dev) == devices[i].vend && > - pci_get_device(dev) == devices[i].dev) { > - > + for (i = 0; i < num_detached; i++) > + if (pci_get_vendor(dev) == pci_get_vendor(detached_devices[i]) && > + pci_get_device(dev) == pci_get_device(detached_devices[i])) { > device_set_desc(dev, "Intel(R) DPDK PCI Device"); This is an old name. You can now rename "Intel(R) DPDK" to "DPDK".