From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: allow updates to build config on make install Date: Wed, 14 May 2014 14:54:44 +0200 Message-ID: <1983230.AZ6L98DUtD@xps13> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> <1725713.WtaYEVcYoT@xps13> <59AF69C657FD0841A61C55336867B5B01AA19761@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Richardson, Bruce" Return-path: In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA19761-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-05-14 12:33, Richardson, Bruce: > > From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] > > > > You would like to have a synchronization of your generated .config file > > with the configuration template. But it's not possible for the simple > > reason that you may have modified your .config file so there is no simple > > correlation with the original template. > > Would you agree then that the ideal state matrix for a make install should > probably be: * template unmodified, config unmodified - No issue - > regenerate or not as best suits the code * template unmodified, config > modified - don't regenerate, keep local config * template modified, config > modified - flag an error, since continuing compile with old config on new > code will lead to undefined build results, since config template changes > rarely occur without code changes to go with them. * template modified, > config unmodified - regenerate new config, overwriting old one, for the > same reason above. [Optionally print out message stating that the config is > being regenerated] > > Does this seem reasonable to you? The last case is the common case for me in > development, as I've had multiple build errors and unexpected build results > in the last week alone due to config template changes not propagating as I > switch development branches to work on different features. It seems reasonable. So you plan to send a v2 with this algorithm? -- Thomas