From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3] eal: add counter size for efd clean
Date: Mon, 16 Oct 2017 12:45:36 +0200
Message-ID: <1985896.boakGMOk3P@xps>
References: <1502636600-46889-1-git-send-email-jingjing.wu@intel.com>
 <4513487.fCd9laRvq9@xps>
 <9BB6961774997848B5B42BEC655768F810E96F36@SHSMSX103.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, "Tan, Jianfeng" <jianfeng.tan@intel.com>,
 "shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "santosh.shukla@caviumnetworks.com" <santosh.shukla@caviumnetworks.com>,
 Tomasz Duszynski <tdu@semihalf.com>, Jacek Siuda <jck@semihalf.com>,
 "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
To: "Wu, Jingjing" <jingjing.wu@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 28C381B646
 for <dev@dpdk.org>; Mon, 16 Oct 2017 12:45:38 +0200 (CEST)
In-Reply-To: <9BB6961774997848B5B42BEC655768F810E96F36@SHSMSX103.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/10/2017 12:29, Wu, Jingjing:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > Hi,
> > 
> > 24/08/2017 04:10, Jingjing Wu:
> > >         } else if (intr_handle->type == RTE_INTR_HANDLE_VDEV) {
> > > -               /* do nothing, and let vdev driver to initialize this struct */
> > > +               /* only check, initialization would be done in vdev driver.*/
> > > +               if (intr_handle->efd_counter_size >
> > > +                   sizeof(union rte_intr_read_buffer)) {
> > > +                       RTE_LOG(ERR, EAL, "the efd_counter_size is oversized");
> > > +                       return -EINVAL;
> > > +               }
> > 
> > How interrupts are working with other buses?
> > 
> > Is it something we should manage in bus drivers code?
> 
> Any plan to move interrupts from EAL to bus?

It is an open question :)