From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] examples/distributor: fix missing ";
	" in debug macro
Date: Fri, 05 Jun 2015 22:45:04 +0200
Message-ID: <19910784.6F5piXXB0d@xps13>
References: <1433520077-11234-1-git-send-email-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 78666C338
 for <dev@dpdk.org>; Fri,  5 Jun 2015 22:45:59 +0200 (CEST)
Received: by wifx6 with SMTP id x6so31969853wif.0
 for <dev@dpdk.org>; Fri, 05 Jun 2015 13:45:58 -0700 (PDT)
In-Reply-To: <1433520077-11234-1-git-send-email-bruce.richardson@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-06-05 17:01, Bruce Richardson:
> The macro to turn on additional debug output when the app was compiled
> with "-DDEBUG" was missing a ";".

It shows that such dead code is almost never tested.
It would be saner if this command would return no result:
	git grep 'ifdef.*DEBUG' examples
		examples/distributor/main.c:#ifdef DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/l3fwd-acl/main.c:#ifdef L3FWDACL_DEBUG
		examples/packet_ordering/main.c:#ifdef DEBUG
		examples/vhost/main.c:#ifdef DEBUG
		examples/vhost/main.h:#ifdef DEBUG
		examples/vhost_xen/main.c:#ifdef DEBUG
		examples/vhost_xen/main.h:#ifdef DEBUG

There is no good reason to not use CONFIG_RTE_LOG_LEVEL to trigger debug build.