From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] kni: Add set_rx_mode callback to handle multicast groups Date: Tue, 16 Jun 2015 17:31:54 +0200 Message-ID: <19936393.CaRDrBdnp3@xps13> References: <20150602092155.588bbb2e@miho> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Johan Faltstrom To: Simon Kagstrom Return-path: Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by dpdk.org (Postfix) with ESMTP id 516BAC324 for ; Tue, 16 Jun 2015 17:32:53 +0200 (CEST) Received: by wicnd19 with SMTP id nd19so2036420wic.1 for ; Tue, 16 Jun 2015 08:32:53 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > We did some (very basic) tests with IGMP, which involves adding multicast > > addresses to ETH interfaces. This is done via the ip tool, an example can be found > > on e.g., > > > > http://superuser.com/questions/324824/linux-built-in-or-open-source-program- > > to-join-multicast-group > > > > and this will fail on KNI interfaces because of an unimplemented ioctl > > SIOCADDMULTI. The patch simply adds an empty callback for set_rx_mode > > (typically used for setting up hardware) so that the ioctl succeeds. > > This is the same thing as the Linux tap interface does. > > > > Signed-off-by: Simon Kagstrom > > Signed-off-by: Johan Faltstrom > Acked-by: Helin Zhang Applied, thanks