From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eal: fix duplicate function declaration Date: Sun, 18 Nov 2018 13:41:38 +0100 Message-ID: <1994389.ETnpRDjGGD@xps> References: <20181114112005.16378-1-kevin.laatz@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Burakov, Anatoly" To: Kevin Laatz Return-path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id D88184C8E for ; Sun, 18 Nov 2018 13:41:43 +0100 (CET) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/11/2018 12:24, Burakov, Anatoly: > On 14-Nov-18 11:20 AM, Kevin Laatz wrote: > > The rte_eal_get_runtime_dir() function is currently being declared in two > > header files. > > > > This API was made public in commit 6911c9fd8fbe ("eal: export function to > > get runtime directory"), adding it to rte_eal.h. To make it public, the > > 'rte' prefix was added to the function so it needed to be modified in the > > original location of the declaration, eal_filesystem.h. By only modifying, > > and not removing the decalration, it is now a duplicate. > > > > This patch removes the declaration from eal_filesystem.h. > > > > Fixes: 6911c9fd8fbe ("eal: export function to get runtime directory") > > > > Reported-by: Anatoly Burakov > > Signed-off-by: Kevin Laatz > > > > --- > > v2: > > - Fix commit message (checkpatch warning) > > --- > > I was too late to ack the first one... > > Acked-by: Anatoly Burakov Applied, thanks