From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C064C0650F for ; Thu, 8 Aug 2019 11:31:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D1C7C217F4 for ; Thu, 8 Aug 2019 11:31:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="hdG+so3P"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Ya6yIl4I" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1C7C217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D93C21BE00; Thu, 8 Aug 2019 13:31:02 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 7BF381BDFF; Thu, 8 Aug 2019 13:31:01 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0118F21EBC; Thu, 8 Aug 2019 07:31:01 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 08 Aug 2019 07:31:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=bumh93qh3iVw6aY8aqDkFvT0cJq/vZQB2WzWI+x8nlg=; b=hdG+so3Pu8zS 8yyvMCmt9e9tRmruIfhui6NoBftuWn0E1a9K99ZAfGwqsNWZSODpRhYJqD8LA9Vg Ej/nohv5JfEbip492d/d3vjMyVjwnbuvy8Z5e499J0koW4AW/NNxBCFWujreYlDA 0bAVsYDExQIX4grH8pIdWDYpO4sJE68= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=bumh93qh3iVw6aY8aqDkFvT0cJq/vZQB2WzWI+x8n lg=; b=Ya6yIl4IvI4WoTKmAP8uzjbIpojyJIEwN/CO0F2Np82y1sutMfaAqjupM o8EanEq4S0A1l/FwL+TpQPFjkqknmSrqvoH8VPaTmrbbKbKexs9qRILcMx2SQ1Go +4bJZddZ5gitAJVzSUCyZpYaTjvGCAi6+2fzvas14YHq1BNgoREjfARHCpgA/RyJ Wuop49rh43gxPDw76PxTNA7PeLuTLo3ZGPsDDEG1EmIG7oDZpd6MpJzX3WMmWy6I OLGDAUPqaT/P9QgaxTq1zuZcP7zkG6keOvYXN9SEcc7m6LmwWAUQmYMLpfoUJLVM 1XBLZsuMb/Y/d/P0NgLN+s5RzB1ng== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduhedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeelfedriedrudegledruddugeenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 572B6380074; Thu, 8 Aug 2019 07:30:59 -0400 (EDT) From: Thomas Monjalon To: Congwen Zhang Cc: stable@dpdk.org, wenzhuo.lu@intel.com, dev@dpdk.org, qi.z.zhang@intel.com Date: Thu, 08 Aug 2019 13:30:57 +0200 Message-ID: <1997420.7iUIcqndAy@xps> In-Reply-To: <1565224640-24239-1-git-send-email-zhang.congwen@zte.com.cn> References: <1565224640-24239-1-git-send-email-zhang.congwen@zte.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/ixgbe: fix offset value check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/08/2019 02:37, Congwen Zhang: > The "and" condition offset == 0 && offset == NVM_INVALID_PTR > can never be true. > > Fixes: cf3af5aa56c9 ("net/ixgbe/base: add functions to get version info") > Cc: stable@dpdk.org > > Signed-off-by: Congwen Zhang > Acked-by: Xiaolong Ye Applied, thanks Note: it looks simple enough to be merged in 19.08 post rc4.