From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] cxgbe: fix unnecessary check for freelist existence while freeing rxq Date: Sun, 13 Dec 2015 00:55:03 +0100 Message-ID: <1999328.glrlqgBIyh@xps13> References: <66655e2d7666da09b80174d265eef304b8d93470.1449821728.git.rahul.lakkireddy@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Felix Marti , Nirranjan Kirubaharan , Kumar Sanghvi To: Rahul Lakkireddy Return-path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id 54E2F8E81 for ; Sun, 13 Dec 2015 00:56:20 +0100 (CET) Received: by mail-wm0-f41.google.com with SMTP id p66so1192650wmp.0 for ; Sat, 12 Dec 2015 15:56:20 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > When refilling freelists for the first time and if it fails, the rxq is > > freed and returns ENOMEM. There is a check while freeing hardware rxq to > > pass freelist context id if the freelist exists or 0xffff otherwise. > > The error path is only reached if freelist exists. So, fix is to remove > > the useless check for freelist existence. > > > > Thanks to John McNamara for reporting it. > > > > Coverity issue: 107108 > > Fixes: 92c8a63223e5 ("cxgbe: add device configuration and Rx support") > > > > Signed-off-by: Rahul Lakkireddy > > Signed-off-by: Kumar Sanghvi > > Thanks for updating the Coverity Triage for the issue. > > Acked-by: John McNamara Applied, thanks