From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 01/12] virtio: move device initialization in a function Date: Tue, 11 Oct 2016 14:30:59 +0200 Message-ID: <19b2b7af-69af-24e6-8a81-d4557d6fa413@redhat.com> References: <1469088510-7552-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-1-git-send-email-olivier.matz@6wind.com> <1475485223-30566-2-git-send-email-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net, xiao.w.wang@intel.com To: Olivier Matz , dev@dpdk.org, yuanhan.liu@linux.intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6892D2B98 for ; Tue, 11 Oct 2016 14:31:05 +0200 (CEST) In-Reply-To: <1475485223-30566-2-git-send-email-olivier.matz@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, On 10/03/2016 11:00 AM, Olivier Matz wrote: > Move all code related to device initialization in a new function > virtio_init_device(). > > This commit brings no functional change, it prepares the next commits > that will add the offload support. For that, it will be needed to > reinitialize the device from ethdev->configure(), using this new > function. > > Signed-off-by: Olivier Matz > --- > drivers/net/virtio/virtio_ethdev.c | 99 ++++++++++++++++++++++---------------- > 1 file changed, 58 insertions(+), 41 deletions(-) Makes sense, feel free to add my: Reviewed-by: Maxime Coquelin Thanks, Maxime