From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
Subject: Re: [PATCH v1 06/11] config: add build enablement for
 IPN3KE
Date: Wed, 6 Mar 2019 12:45:25 +0000
Message-ID: <1a666d01-11a5-e03b-08dd-10312d81f588@linux.intel.com>
References: <1551338000-120348-1-git-send-email-rosen.xu@intel.com>
 <1551338000-120348-7-git-send-email-rosen.xu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: ferruh.yigit@intel.com, tianfei.zhang@intel.com, dan.wei@intel.com,
 andy.pei@intel.com, qiming.yang@intel.com, haiyue.wang@intel.com,
 santos.chen@intel.com, zhang.zhang@intel.com
To: Rosen Xu <rosen.xu@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2F2B25587
 for <dev@dpdk.org>; Wed,  6 Mar 2019 13:45:29 +0100 (CET)
In-Reply-To: <1551338000-120348-7-git-send-email-rosen.xu@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2/28/2019 7:13 AM, Rosen Xu wrote:
> Add build enablement for Intel FPGA Acceleration
> NIC IPN3KE.

No need to make this a separate patch, can squash into previous one.

> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>
> ---
>  config/common_base | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/config/common_base b/config/common_base
> index 7c6da51..4fac8ba 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -316,6 +316,12 @@ CONFIG_RTE_LIBRTE_AVF_DEBUG_RX=n
>  CONFIG_RTE_LIBRTE_AVF_16BYTE_RX_DESC=n
>  
>  #
> +# Compile burst-oriented IPN3KE PMD driver
> +#
> +CONFIG_RTE_LIBRTE_IPN3KE_PMD=n

Why PMD is disabled by default?

> +CONFIG_RTE_LIBRTE_IPN3KE_DEBUG=n

_DEBUG seems not used at all, if so can you please remove it?

> +
> +#
>  # Compile burst-oriented Mellanox ConnectX-3 (MLX4) PMD
>  #
>  CONFIG_RTE_LIBRTE_MLX4_PMD=n
>