From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 04/22] qede/base: update base driver Date: Fri, 30 Sep 2016 17:44:56 +0100 Message-ID: <1ac6d74c-cc78-4efd-275c-9645952fb8a0@intel.com> References: <1475219169-8774-1-git-send-email-rasesh.mody@qlogic.com> <1475219169-8774-5-git-send-email-rasesh.mody@qlogic.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Dept-EngDPDKDev@qlogic.com, Bruce Richardson , Thomas Monjalon To: Rasesh Mody , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 55FCB56AB for ; Fri, 30 Sep 2016 18:44:59 +0200 (CEST) In-Reply-To: <1475219169-8774-5-git-send-email-rasesh.mody@qlogic.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Rasesh, On 9/30/2016 8:05 AM, Rasesh Mody wrote: > This patch updates the base driver and incorporates necessary changes > required to bring in the new firmware 8.10.9.0. > > In addition, it would allow driver to add new functionalities that might > be needed in future. > > Signed-off-by: Rasesh Mody > --- > doc/guides/nics/features/qede.ini | 2 + > doc/guides/nics/features/qede_vf.ini | 2 + > doc/guides/nics/qede.rst | 15 +- > drivers/net/qede/Makefile | 4 + > drivers/net/qede/base/bcm_osal.c | 21 + > drivers/net/qede/base/bcm_osal.h | 10 + > drivers/net/qede/base/common_hsi.h | 1257 ++++++++++++++++++--- > drivers/net/qede/base/ecore.h | 172 ++- > drivers/net/qede/base/ecore_chain.h | 31 +- > drivers/net/qede/base/ecore_cxt.c | 371 +++++- > drivers/net/qede/base/ecore_cxt.h | 52 +- > drivers/net/qede/base/ecore_cxt_api.h | 15 - > drivers/net/qede/base/ecore_dcbx.c | 587 +++++++++- > drivers/net/qede/base/ecore_dcbx.h | 18 +- > drivers/net/qede/base/ecore_dcbx_api.h | 128 ++- > drivers/net/qede/base/ecore_dev.c | 1627 ++++++++++++++++++++------- > drivers/net/qede/base/ecore_dev_api.h | 129 ++- > drivers/net/qede/base/ecore_gtt_reg_addr.h | 10 + > drivers/net/qede/base/ecore_hsi_common.h | 1146 ++++++++++++++----- > drivers/net/qede/base/ecore_hsi_eth.h | 991 ++++++++++++---- > drivers/net/qede/base/ecore_hw.c | 214 ++-- > drivers/net/qede/base/ecore_hw.h | 47 +- > drivers/net/qede/base/ecore_hw_defs.h | 33 +- > drivers/net/qede/base/ecore_init_fw_funcs.c | 327 ++++-- > drivers/net/qede/base/ecore_init_fw_funcs.h | 182 ++- > drivers/net/qede/base/ecore_init_ops.c | 5 +- > drivers/net/qede/base/ecore_init_ops.h | 14 +- > drivers/net/qede/base/ecore_int.c | 313 +++--- > drivers/net/qede/base/ecore_int.h | 19 +- > drivers/net/qede/base/ecore_int_api.h | 11 + > drivers/net/qede/base/ecore_iov_api.h | 473 ++------ > drivers/net/qede/base/ecore_iro.h | 222 ++-- > drivers/net/qede/base/ecore_iro_values.h | 108 +- > drivers/net/qede/base/ecore_l2.c | 407 +++---- > drivers/net/qede/base/ecore_l2.h | 57 +- > drivers/net/qede/base/ecore_l2_api.h | 18 +- > drivers/net/qede/base/ecore_mcp.c | 707 +++++++++--- > drivers/net/qede/base/ecore_mcp.h | 85 +- > drivers/net/qede/base/ecore_mcp_api.h | 194 +++- > drivers/net/qede/base/ecore_proto_if.h | 59 + > drivers/net/qede/base/ecore_rt_defs.h | 639 +++++------ > drivers/net/qede/base/ecore_sp_api.h | 5 +- > drivers/net/qede/base/ecore_sp_commands.c | 83 +- > drivers/net/qede/base/ecore_sp_commands.h | 30 + > drivers/net/qede/base/ecore_spq.c | 181 +-- > drivers/net/qede/base/ecore_spq.h | 26 +- > drivers/net/qede/base/ecore_sriov.c | 1596 ++++++++++++++++---------- > drivers/net/qede/base/ecore_sriov.h | 149 +-- > drivers/net/qede/base/ecore_vf.c | 736 +++++++----- > drivers/net/qede/base/ecore_vf.h | 224 +--- > drivers/net/qede/base/ecore_vf_api.h | 93 +- > drivers/net/qede/base/ecore_vfpf_if.h | 165 ++- > drivers/net/qede/base/eth_common.h | 387 ++++--- > drivers/net/qede/base/mcp_public.h | 629 +++++++++-- > drivers/net/qede/base/nvm_cfg.h | 623 ++++++++-- > drivers/net/qede/base/reg_addr.h | 36 + > drivers/net/qede/qede_eth_if.c | 1 + > drivers/net/qede/qede_main.c | 20 +- > drivers/net/qede/qede_rxtx.h | 4 + > 59 files changed, 10857 insertions(+), 4853 deletions(-) Thank you for the update, base driver patch update now reduced from "14653 insertions(+), 8536 deletions(-)" to "10857 insertions(+), 4853 deletions(-)" But this is still to big for reviewing, specially there are some low hanging fruits for cleanup, like big chunk of comment updates or whitespace updates or non base driver codes in the patch. If the expectation is that somebody non maintainer review the code, understand it and highlight any possible defects, I believe this patch is too big and needs to be split more into logical pieces, but since this is a driver code and a little special, and it may not be possible to completely understand the code without knowing underlying hardware, I am not sure how to proceed and adding Bruce and Thomas to cc for guidance. Thanks, ferruh