From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v8 25/25] eal/pci: Create rte_device list and fallback on its members Date: Thu, 8 Sep 2016 09:33:53 +0100 Message-ID: <1ac929d7-f550-7070-96a1-d8d4d940a6f4@intel.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-26-git-send-email-shreyansh.jain@nxp.com> <57C46892.1080103@intel.com> <355fb63b-c78b-1370-5d2f-66c7ca1bed4e@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: viktorin@rehivetech.com, david.marchand@6wind.com, thomas.monjalon@6wind.com, hemant.agrawal@nxp.com To: Shreyansh Jain , dev@dpdk.org Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 46AA88DB5 for ; Thu, 8 Sep 2016 10:33:57 +0200 (CEST) In-Reply-To: <355fb63b-c78b-1370-5d2f-66c7ca1bed4e@nxp.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2016 6:55 AM, Shreyansh Jain wrote: > On Monday 29 August 2016 10:23 PM, Ferruh Yigit wrote: >> On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >>> Now that rte_device is available, drivers can start using its members (numa, >>> name) as well as link themselves into another rte_device list. >>> >>> As of now no one is using this list, but can be used for moving over all >>> devices (pdev/vdev/Xdev) and perform bulk actions (like cleanup). >>> >>> Signed-off-by: Jan Viktorin >>> Signed-off-by: Shreyansh Jain >>> --- >>> app/test/virtual_pmd.c | 4 ++-- >>> drivers/net/fm10k/fm10k_ethdev.c | 6 +++--- >>> drivers/net/i40e/i40e_ethdev.c | 6 ++++-- >>> drivers/net/virtio/virtio_pci.c | 5 +++-- >>> lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- >>> lib/librte_eal/common/eal_common_pci.c | 11 ++++++----- >>> lib/librte_eal/common/include/rte_pci.h | 3 +-- >>> lib/librte_eal/linuxapp/eal/eal_pci.c | 7 +++++-- >>> lib/librte_ether/rte_ethdev.c | 2 +- >>> 9 files changed, 26 insertions(+), 20 deletions(-) >> >> mlx5.c needs to be updated too: >> >> CC mlx5.o >> ..../drivers/net/mlx5/mlx5.c:514:34: error: no member named 'devargs' in >> 'struct rte_pci_device' >> err = mlx5_args(priv, pci_dev->devargs); >> ~~~~~~~ ^ >> >> > > Updated in v9 but I haven't yet been able to compile and verify mlx* and > szedata2*. > Thanks for the v9, I have my setup and can test compiling them.