From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH] eal: fslmc bus need vfio enabled for non PCI
	case as well
Date: Fri, 6 Oct 2017 21:52:51 +0530
Message-ID: <1afffe26-d574-0c6d-6101-836aaca1a37b@nxp.com>
References: <1499946530-29581-1-git-send-email-hemant.agrawal@nxp.com>
 <2584395.73f1Oakct5@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Thomas Monjalon <thomas@monjalon.net>, <anatoly.burakov@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0071.outbound.protection.outlook.com [104.47.37.71])
 by dpdk.org (Postfix) with ESMTP id 995D81B1EC
 for <dev@dpdk.org>; Fri,  6 Oct 2017 18:22:58 +0200 (CEST)
In-Reply-To: <2584395.73f1Oakct5@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/6/2017 5:11 AM, Thomas Monjalon wrote:
> 13/07/2017 13:48, Hemant Agrawal:
>> In case no_pci is configured, fslmc bus will still need the
>> the vfio to be enabled.
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>> +#ifdef RTE_LIBRTE_FSLMC_BUS
>> +	if (!vfio_enabled) {
>> +		if (!vfio_enable("vfio_fsl_mc"))
>> +			vfio_enabled = 1;
>> +	}
>> +#endif
>
> It seems to be a hack.
> VFIO is not only PCI.
> Why --no-pci is impacting VFIO?
>
> Anatoly?
>

At present there are only 2 users of VFIO. PCI and fsl-mc bus.


One options is that we always enable vfio irrespective of --no-pci flag. 
My believe is that vfio-pci will be present in most system supporting 
any other flavor of vfio (platform, fsl-mc etc).

The other option is what I proposed. i.e. if vfio is not already enabled 
the platform is FSLMC bus, enable it.

regards,
Hemant