From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Traynor Subject: Re: [PATCH] ethdev: decrease log level for successful API Date: Thu, 2 Aug 2018 19:39:04 +0100 Message-ID: <1b06046c-2165-c31d-afc3-3f7d093816f9@redhat.com> References: <1533213223-24028-1-git-send-email-ktraynor@redhat.com> <1533234804-5972-1-git-send-email-ktraynor@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Kevin Traynor , "dev@dpdk.org" Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 1D4001B4EF for ; Thu, 2 Aug 2018 20:39:06 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D3EF40216F7 for ; Thu, 2 Aug 2018 18:39:05 +0000 (UTC) In-Reply-To: <1533234804-5972-1-git-send-email-ktraynor@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" subject prefix not updated - will resend as [PATCH v2] On 08/02/2018 07:33 PM, Kevin Traynor wrote: > Change log level of messages from ERR to INFO where > the post condition of the API is success, but no action > was actually needed as the condition already existed. > e.g. calling rte_eth_dev_start() for a device that is > already started. > > Fixes: bea1e0c70cfc ("ethdev: convert static log type usage to dynamic") > > Signed-off-by: Kevin Traynor > --- > lib/librte_ethdev/rte_ethdev.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index c7ab157..4c32025 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -797,5 +797,5 @@ struct rte_eth_dev * > > if (dev->data->rx_queue_state[rx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) { > - RTE_ETHDEV_LOG(ERR, > + RTE_ETHDEV_LOG(INFO, > "Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n", > rx_queue_id, port_id); > @@ -824,5 +824,5 @@ struct rte_eth_dev * > > if (dev->data->rx_queue_state[rx_queue_id] == RTE_ETH_QUEUE_STATE_STOPPED) { > - RTE_ETHDEV_LOG(ERR, > + RTE_ETHDEV_LOG(INFO, > "Queue %"PRIu16" of device with port_id=%"PRIu16" already stopped\n", > rx_queue_id, port_id); > @@ -857,5 +857,5 @@ struct rte_eth_dev * > > if (dev->data->tx_queue_state[tx_queue_id] != RTE_ETH_QUEUE_STATE_STOPPED) { > - RTE_ETHDEV_LOG(ERR, > + RTE_ETHDEV_LOG(INFO, > "Queue %"PRIu16" of device with port_id=%"PRIu16" already started\n", > tx_queue_id, port_id); > @@ -882,5 +882,5 @@ struct rte_eth_dev * > > if (dev->data->tx_queue_state[tx_queue_id] == RTE_ETH_QUEUE_STATE_STOPPED) { > - RTE_ETHDEV_LOG(ERR, > + RTE_ETHDEV_LOG(INFO, > "Queue %"PRIu16" of device with port_id=%"PRIu16" already stopped\n", > tx_queue_id, port_id); > @@ -1287,5 +1287,5 @@ struct rte_eth_dev * > > if (dev->data->dev_started != 0) { > - RTE_ETHDEV_LOG(ERR, > + RTE_ETHDEV_LOG(INFO, > "Device with port_id=%"PRIu16" already started\n", > port_id); > @@ -1319,5 +1319,5 @@ struct rte_eth_dev * > > if (dev->data->dev_started == 0) { > - RTE_ETHDEV_LOG(ERR, > + RTE_ETHDEV_LOG(INFO, > "Device with port_id=%"PRIu16" already stopped\n", > port_id); >