From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH v3] kni: convert license headers to SPDX tags
Date: Wed, 10 Jan 2018 12:16:30 +0530
Message-ID: <1b245a10-1af9-ebca-021c-63680f4e1cc6@nxp.com>
References: <20171219000519.53666-1-ferruh.yigit@intel.com>
 <20180109151229.79325-1-ferruh.yigit@intel.com> <4205065.psd1szYZHI@xps>
 <eb165296-fcd4-6f93-4429-dc15799cee19@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0072.outbound.protection.outlook.com [104.47.36.72])
 by dpdk.org (Postfix) with ESMTP id 3456D1B161
 for <dev@dpdk.org>; Wed, 10 Jan 2018 07:46:34 +0100 (CET)
In-Reply-To: <eb165296-fcd4-6f93-4429-dc15799cee19@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/9/2018 9:00 PM, Ferruh Yigit wrote:
> On 1/9/2018 3:24 PM, Thomas Monjalon wrote:
>> 09/01/2018 16:12, Ferruh Yigit:
>>> --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>>> +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_kni_common.h
>>> +/* SPDX-License-Identifier: (BSD-3-Clause OR LGPL-2.1) */
>>> +/*
>>> + * Copyright(c) 2007-2014 Intel Corporation.
>>>   */
>>
>>> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
>>> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * Copyright(c) 2010-2014 Intel Corporation.
>>>   */
>>
>> Why these empty lines between SPDX and Copyright?
>
> For kernel module files I followed Linux style, as "//" comments in .c files.
> I don't have strong opinion about this...
>
>
I think it is just fine to use the Linux style for kernel module based 
code.
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>