dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Zhichao Zeng <zhichaox.zeng@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Ferruh Yigit <ferruh.yigit@amd.com>,
	 Shahaf Shuler <shahafs@nvidia.com>
Subject: RE: [PATCH] examples/ip_reassembly: remove conflicting Tx offload
Date: Fri, 19 Sep 2025 07:13:58 +0000	[thread overview]
Message-ID: <1b34bebb0c2544468c31e4a566e7335d@huawei.com> (raw)
In-Reply-To: <20250919071213.818567-1-zhichaox.zeng@intel.com>



> 
> IP packet reassembly requires the MULTI_SEGS offload to be enabled in order
> to handle fragmented packets across multiple memory segments. However, the
> MBUF_FAST_FREE offload conflicts with MULTI_SEGS and cannot be enabled
> simultaneously.
> 
> Remove the MBUF_FAST_FREE offload to avoid conflicts with MULTI_SEGS.
> 
> Fixes: 9df56e69ee3f ("examples/ip_reassembly: convert to new ethdev offloads
> API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> ---
>  examples/ip_reassembly/main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c
> index 17ae76d4ba..294fd38889 100644
> --- a/examples/ip_reassembly/main.c
> +++ b/examples/ip_reassembly/main.c
> @@ -1093,9 +1093,6 @@ main(int argc, char **argv)
>  		n_tx_queue = nb_lcores;
>  		if (n_tx_queue > MAX_TX_QUEUE_PER_PORT)
>  			n_tx_queue = MAX_TX_QUEUE_PER_PORT;
> -		if (dev_info.tx_offload_capa &
> RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)
> -			local_port_conf.txmode.offloads |=
> -				RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
> 
>  		local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
>  			dev_info.flow_type_rss_offloads;
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>

> 2.34.1
> 


  reply	other threads:[~2025-09-19  7:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  7:12 [PATCH] examples/ip_reassembly: remove conflicting Tx offload Zhichao Zeng
2025-09-19  7:13 ` Konstantin Ananyev [this message]
2025-09-28  9:04 ` Xu, HailinX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b34bebb0c2544468c31e4a566e7335d@huawei.com \
    --to=konstantin.ananyev@huawei.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=shahafs@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=zhichaox.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).