From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v4 20/22] net/atlantic: LED control DPDK and
	private APIs
Date: Wed, 10 Oct 2018 11:32:19 +0100
Message-ID: <1bb197a4-2bc2-1dc6-1ca9-f57d39d5b27d@intel.com>
References: <cover.1539075891.git.igor.russkikh@aquantia.com>
 <a3903743df60693a271a7e0d4f7690f2160dd079.1539075891.git.igor.russkikh@aquantia.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Pavel Belous <Pavel.Belous@aquantia.com>
To: Igor Russkikh <Igor.Russkikh@aquantia.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 8A1941B3C0
 for <dev@dpdk.org>; Wed, 10 Oct 2018 12:32:33 +0200 (CEST)
In-Reply-To: <a3903743df60693a271a7e0d4f7690f2160dd079.1539075891.git.igor.russkikh@aquantia.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/9/2018 10:32 AM, Igor Russkikh wrote:
> Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
> Signed-off-by: Pavel Belous <Pavel.Belous@aquantia.com>

<...>

> +/**
> + * This is a custom API for adapter's LED controls.
> + *
> + * @param dev
> + *   Ethernet device to apply control to
> + * @param control
> + *   6 bit value (3 leds each 2bit):
> + *   - bits 0-1: LED0 control
> + *   - bits 2-3: LED1 control
> + *   - bits 4-5: LED2 control
> + *   Each two bit control value is:
> + *   - 0: Firmware manages this LED activity
> + *   - 1: Permanent ON
> + *   - 2: Blinking
> + *   - 3: Permanent OFF
> + *
> + * @return
> + *   - (0) if successful.
> + *   - (-ENOTSUP) if hardware doesn't support.
> + */
> +int rte_pmd_atl_dev_led_control(int port, int control);

What is the intention here, making PMD specific public API?
If so .map file is missing but we discourage using PMD specific APIs,

can't it be possible to extend exiting led related dev_ops in a generic way to
cover your use case?