From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v2] meson: remove build warnings
Date: Tue, 19 Mar 2019 17:36:35 +0000
Message-ID: <1bc7f7793e60adc4abd36568b346bdcf0569ba64.camel@debian.org>
References: <20190318162804.28974-1-jerinj@marvell.com>
 <20190319172150.12765-1-jerinj@marvell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "bruce.richardson@intel.com"
 <bruce.richardson@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190319172150.12765-1-jerinj@marvell.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2019-03-19 at 17:22 +0000, Jerin Jacob Kollanukkaran wrote:
> From: Jerin Jacob <jerinj@marvell.com>
>=20
> Remove the following warning by comparing string to string.
>=20
> config/arm/meson.build:153: WARNING: Trying to compare values of
> different types (list, str) using =3D=3D.
>=20
> Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for
> ARM")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>=20
> v2: Remove meson version related warning as bumbing the version needs
> techboard approval.
>=20
> ---
>  config/arm/meson.build | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 8e892fa77..170a4981a 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -116,8 +116,8 @@ else
>  			cmd_output =3D
> cmd.stdout().to_lower().strip().split(' ')
>  		endif
>  		# Set to generic if variable is not found
> -		machine =3D get_variable('impl_' + cmd_output[0],
> 'generic')
> -		if machine =3D=3D 'generic'
> +		machine =3D get_variable('impl_' + cmd_output[0],
> ['generic'])
> +		if machine[0] =3D=3D 'generic'
>  			machine =3D impl_generic
>  			cmd_output =3D cmd_generic
>  		endif

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi