From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/nfp: support new HW offloads API
Date: Tue, 27 Mar 2018 19:25:42 +0100
Message-ID: <1c209b93-bdba-cff7-cb70-4971e80997d0@intel.com>
References: <1521124237-47243-1-git-send-email-alejandro.lucero@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
To: Alejandro Lucero <alejandro.lucero@netronome.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id A0C124CBB
 for <dev@dpdk.org>; Tue, 27 Mar 2018 20:25:45 +0200 (CEST)
In-Reply-To: <1521124237-47243-1-git-send-email-alejandro.lucero@netronome.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 3/15/2018 2:30 PM, Alejandro Lucero wrote:
> In next 18.05 the old hw offload API will be removed. This patch adds
> support for just the new hw offload API.
> 
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>

<...>

> -	if (rxmode->enable_scatter) {
> +	if (!(rxmode->offloads & DEV_RX_OFFLOAD_CRC_STRIP))
> +		PMD_INIT_LOG(INFO, "HW does strip CRC. No configurable!");

Also this behavior is changing, not providing CRC_STRIP will be by default
stripping [2], this check should be removed.

[2]
https://dpdk.org/ml/archives/dev/2018-March/093489.htmlhttps://dpdk.org/ml/archives/dev/2018-March/093489.html

<...>

> +	dev_conf = &dev->data->dev_conf;
> +	rxmode = &dev_conf->rxmode;
> +
> +	if (rx_conf->offloads != rxmode->offloads) {
> +		RTE_LOG(ERR, PMD, "queue %u rx offloads not as port offloads\n",
> +				  queue_idx);
> +		RTE_LOG(ERR, PMD, "\tport: %" PRIx64 "\n", rxmode->offloads);
> +		RTE_LOG(ERR, PMD, "\tqueue: %" PRIx64 "\n", rx_conf->offloads);
> +		return -EINVAL;
> +	}

The offload API is changing [1], this check is no more valid. If PMD is not
supporting queue specific offload app will not send port offloads here.

[1]
https://dpdk.org/ml/archives/dev/2018-March/092978.html

<...>

> +	dev_conf = &dev->data->dev_conf;
> +	txmode = &dev_conf->txmode;
> +
> +	if (tx_conf->offloads != txmode->offloads) {
> +		RTE_LOG(ERR, PMD, "queue %u tx offloads not as port offloads",
> +				  queue_idx);
> +		return -EINVAL;
> +	}
> +

Same as above.