From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 2/6] net/mvpp2: use common code to
 initialize DMA
Date: Fri, 24 Aug 2018 17:46:21 +0100
Message-ID: <1d3a475c-1111-1ccc-d365-bfce148fc8f8@intel.com>
References: <1535113006-9393-1-git-send-email-tdu@semihalf.com>
 <1535122494-30249-1-git-send-email-tdu@semihalf.com>
 <1535122494-30249-3-git-send-email-tdu@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: nsamsono@marvell.com, mw@semihalf.com, Liron Himi <lironh@marvell.com>
To: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 037A37CE7
 for <dev@dpdk.org>; Fri, 24 Aug 2018 18:46:24 +0200 (CEST)
In-Reply-To: <1535122494-30249-3-git-send-email-tdu@semihalf.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 8/24/2018 3:54 PM, Tomasz Duszynski wrote:
> From: Liron Himi <lironh@marvell.com>
> 
> Use common code to initialize MUSDK DMA memory buffers.
> 
> Signed-off-by: Liron Himi <lironh@marvell.com>
> Reviewed-by: Natalie Samsonov <nsamsono@marvell.com>

<...>

> @@ -2653,24 +2651,17 @@ rte_pmd_mrvl_probe(struct rte_vdev_device *vdev)
>  	if (mrvl_dev_num)
>  		goto init_devices;
>  
> -	MRVL_LOG(INFO, "Perform MUSDK initializations");
> -	/*
> -	 * ret == -EEXIST is correct, it means DMA
> -	 * has been already initialized (by another PMD).
> -	 */
> -	ret = mv_sys_dma_mem_init(MRVL_MUSDK_DMA_MEMSIZE);
> -	if (ret < 0) {
> -		if (ret != -EEXIST)
> -			goto out_free_kvlist;
> -		else
> -			MRVL_LOG(INFO,
> -				"DMA memory has been already initialized by a different driver.");
> -	}
> +	MRVL_LOG(INFO, "Perform MUSDK initializations\n");

MRVL_LOG already adding "\n", no need to change original log, a few more below.