From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v1] eal: remove another use of register keyword Date: Mon, 15 Jan 2018 20:18:41 +0200 Message-ID: <1d4491fc-ef3b-72fc-2b60-7f48228e12a1@scylladb.com> References: <20180115113323.24439-1-avi@scylladb.com> <1973968.l2YiJ7Szvs@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon Return-path: Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by dpdk.org (Postfix) with ESMTP id 582D3322C for ; Mon, 15 Jan 2018 19:18:44 +0100 (CET) Received: by mail-wm0-f66.google.com with SMTP id b141so3619549wme.1 for ; Mon, 15 Jan 2018 10:18:44 -0800 (PST) In-Reply-To: <1973968.l2YiJ7Szvs@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01/15/2018 08:00 PM, Thomas Monjalon wrote: > 15/01/2018 12:33, Avi Kivity: >> The 'register' keyword does nothing, and has been removed in C++17. >> >> Remove it for compatibility, like commit 0d5f2ed12f9eb. > Fixes: 0d5f2ed12f9e ("eal: remove use of register keyword") > >> Signed-off-by: Avi Kivity > Applied, thanks. > > Note that "register" is used in some drivers too: > git grep -l '\.*;' drivers/ | sed -r 's,([^/]*/[^/]*/[^/]*/).*,\1,' | sort -u > drivers/bus/dpaa/ > drivers/crypto/dpaa2_sec/ > drivers/crypto/qat/ > drivers/event/sw/ > drivers/net/ark/ > drivers/net/avp/ > drivers/net/bnx2x/ > drivers/net/bnxt/ > drivers/net/e1000/ > drivers/net/i40e/ > drivers/net/ixgbe/ > drivers/net/qede/ > drivers/net/sfc/ > drivers/net/vhost/ > I think those aren't a problem, since they aren't exposed to C++ programs.