From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v5 1/4] app/eventdev: add event timer adapter as a producer Date: Tue, 17 Apr 2018 10:24:32 +0200 Message-ID: <1d6519ba-ebf5-cb53-567d-41f146a295c7@redhat.com> References: <20180318131216.11699-1-pbhagavatula@caviumnetworks.com> <20180406151324.9135-1-pbhagavatula@caviumnetworks.com> <7100b73d-de02-c70e-774f-2c254b63b7ec@redhat.com> <20180417082209.GA3161@ltp-pvn> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Pavan Nikhilesh , jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, erik.g.carrillo@intel.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 5A34E8E76 for ; Tue, 17 Apr 2018 10:24:36 +0200 (CEST) In-Reply-To: <20180417082209.GA3161@ltp-pvn> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/17/2018 10:22 AM, Pavan Nikhilesh wrote: > >> It seems your patch introduce build regression on RHEL 7.5: >> $ gcc --version >> gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) >> >> $ make -j32 install T=x86_64-native-linuxapp-gcc DESTDIR=legacy_destdir >> >> == Build app/test-eventdev >> CC test_perf_common.o >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c: In function >> ‘perf_event_timer_producer’: >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:99:3: error: missing >> initializer for field ‘priority’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .ev.sched_type = t->opt->sched_type_list[0], >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1049:12: >> note: ‘priority’ declared here >> uint8_t priority; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:100:3: error: missing >> initializer for field ‘priority’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL, >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1049:12: >> note: ‘priority’ declared here >> uint8_t priority; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:101:3: error: missing >> initializer for field ‘impl_opaque’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .ev.event_type = RTE_EVENT_TYPE_TIMER, >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1059:12: >> note: ‘impl_opaque’ declared here >> uint8_t impl_opaque; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:102:3: error: missing >> initializer for field ‘impl_opaque’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .state = RTE_EVENT_TIMER_NOT_ARMED, >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1059:12: >> note: ‘impl_opaque’ declared here >> uint8_t impl_opaque; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c: In function >> ‘perf_event_timer_producer_burst’: >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:161:3: error: missing >> initializer for field ‘priority’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .ev.sched_type = t->opt->sched_type_list[0], >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1049:12: >> note: ‘priority’ declared here >> uint8_t priority; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:162:3: error: missing >> initializer for field ‘priority’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .ev.priority = RTE_EVENT_DEV_PRIORITY_NORMAL, >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1049:12: >> note: ‘priority’ declared here >> uint8_t priority; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:163:3: error: missing >> initializer for field ‘impl_opaque’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .ev.event_type = RTE_EVENT_TYPE_TIMER, >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1059:12: >> note: ‘impl_opaque’ declared here >> uint8_t impl_opaque; >> ^ >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:164:3: error: missing >> initializer for field ‘impl_opaque’ of ‘struct ’ >> [-Werror=missing-field-initializers] >> .state = RTE_EVENT_TIMER_NOT_ARMED, >> ^ >> In file included from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.h:14:0, >> from >> /tmp/dpdk_build/app/test-eventdev/test_perf_common.c:5: >> /tmp/dpdk_build/x86_64-native-linuxapp-gcc/include/rte_eventdev.h:1059:12: >> note: ‘impl_opaque’ declared here >> uint8_t impl_opaque; >> ^ >> cc1: all warnings being treated as errors >> make[5]: *** [test_perf_common.o] Error 1 >> make[4]: *** [test-eventdev] Error 2 >> make[3]: *** [app] Error 2 >> make[2]: *** [all] Error 2 >> make[1]: *** [pre_install] Error 2 >> make: *** [install] Error 2 > Hi Maxime, > > This is already fixed on the HEAD. > Please refer to > http://dpdk.org/dev/patchwork/patch/38189/ Thanks for the quick reply, I tested with net-next, so the patch didn't land into it yet. Regards, Maxime > >> >> Regards, >> Maxime > > Thanks, > Pavan. >