From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: postpone ring addresses translations at kick time only Date: Fri, 3 Nov 2017 16:56:42 +0100 Message-ID: <1d70c3b9-67c5-22d8-9312-33e43db0ac70@redhat.com> References: <20171103155235.29869-1-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: mst@redhat.com To: dev@dpdk.org, yliu@fridaylinux.org, lei.a.yao@intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 8650D1B6B3 for ; Fri, 3 Nov 2017 16:56:52 +0100 (CET) In-Reply-To: <20171103155235.29869-1-maxime.coquelin@redhat.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Lei, On 11/03/2017 04:52 PM, Maxime Coquelin wrote: > If multiple queue pairs are created but all are not used, the > device is never started, as unused queues aren't enabled and > their ring addresses aren't translated. The device is changed > to running state when all rings addresses are translated. > > This patch fixes this by postponning rings addresses translation > at kick time unconditionnaly, VHOST_USER_F_PROTOCOL_FEATURES > being negotiated or not. > > Reported-by: Lei Yao > Signed-off-by: Maxime Coquelin > --- > lib/librte_vhost/vhost_user.c | 33 ++++++++------------------------- > 1 file changed, 8 insertions(+), 25 deletions(-) Could you confirm the patch fixes the issue on your side? I tested below cases with and without IOMMU: - Host DPDK queues = 1 / QEMU queues = 1 / Guest DPDK queues = 1 - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 1 - Host DPDK queues = 2 / QEMU queues = 2 / Guest DPDK queues = 2 Thanks, Maxime