From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kevin Traynor Subject: Re: [PATCH v5 05/11] eal: replace rte_panic instances in eventdev Date: Thu, 26 Apr 2018 17:06:55 +0100 Message-ID: <1db20a32-5e21-4142-75cc-7366c64d3bbe@redhat.com> References: <1524518942-1998-1-git-send-email-arnon@qwilt.com> <1524518942-1998-6-git-send-email-arnon@qwilt.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Arnon Warshavsky , thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 0CAD38DA9 for ; Thu, 26 Apr 2018 18:06:59 +0200 (CEST) In-Reply-To: <1524518942-1998-6-git-send-email-arnon@qwilt.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/23/2018 10:28 PM, Arnon Warshavsky wrote: > replace panic calls with log and return value. > > Signed-off-by: Arnon Warshavsky > --- > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 8 +++++--- > lib/librte_eventdev/rte_eventdev_pmd_vdev.h | 8 +++++--- > 2 files changed, 10 insertions(+), 6 deletions(-) > > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > index 8fb6138..6e08705 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > @@ -66,9 +66,11 @@ > RTE_CACHE_LINE_SIZE, > rte_socket_id()); > > - if (eventdev->data->dev_private == NULL) > - rte_panic("Cannot allocate memzone for private " > - "device data"); > + if (eventdev->data->dev_private == NULL) { > + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for private device data", > + __func__); > + return -ENOMEM; > + } > } Similar to 1/11 in that there is some allocate before this and maybe you should jump to the release at the end of the function > > eventdev->dev = &pci_dev->device; > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h > index 8c64a06..b7c08fa 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_vdev.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_vdev.h > @@ -61,9 +61,11 @@ > RTE_CACHE_LINE_SIZE, > socket_id); > > - if (eventdev->data->dev_private == NULL) > - rte_panic("Cannot allocate memzone for private device" > - " data"); > + if (eventdev->data->dev_private == NULL) { > + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for private device data", > + __func__); > + return NULL; > + } > } > > return eventdev; >